• Resolved Thierry

    (@theremingenieur)


    On my website, I have several front page sections which can be addressed from the main menu with the corresponding anchor links (“Welcome”, “Academy”, “Concept”, “Teachers”, and “Contact”) . Today, I accidentally discover that in opposite to earlier behavior, clicking such an anchor link (or on one of the little “up” arrows) makes the scrolling land in a way that the page title or the section page title will be hidden behind the main menu.

    Seen that this wonderful plugin got a lots of updates recently, this might be a minor regression, but I’d like to see it fixed, though, please!

    The page I need help with: [log in to see the link]

Viewing 14 replies - 1 through 14 (of 14 total)
  • Plugin Author Oliver Campion

    (@domainsupport)

    Hi Thierry,

    I’m currently stuck in the mountains due to the chaos at Gatwick airport so cannot release an update until I return … however, I’ve just tested your site on Google Chrome and can see the issue you mention and can see what’s causing it. You’ve changed the margin above the titles which has pulled the titles underneath the menu.

    I don’t think there’s going to be a fix for this combination of features, but I’ll have a think about it.

    Oliver

    Thread Starter Thierry

    (@theremingenieur)

    Hi Oliver,

    as I wrote, it’s not a dramatic issue. It’s more important that you return home safely, first!

    I have set that margin to the maximum by moving the “Content Padding Top” slider fully towards the right for now which gives partly the desired result:
    For sections whose height is smaller than the browser window height, scrolling works correct. But for sections where the height is greater than the browser window height, scrolling goes first in the desired place, but then reverses direction, and the title is half hidden again !?!

    Again, no pressure!

    Have nice and calm festive days!

    Thierry

    Plugin Author Oliver Campion

    (@domainsupport)

    Hi Thierry,

    Can you please elaborate on this giving examples that we can see working (not working) … ?

    for sections where the height is greater than the browser window height, scrolling goes first in the desired place, but then reverses direction, and the title is half hidden again

    … thanks!

    Oliver

    Thread Starter Thierry

    (@theremingenieur)

    I made a little video capturing what happens. I think that this tells more than my clumsy English. Don’t forget, I’m French and thus a foreign language autist… ??

    https://we.tl/t-HKGcD2NyVR

    Plugin Author Oliver Campion

    (@domainsupport)

    Haha, nothing wrong with your English, just having trouble replicating the issue. It’s not doing it on our machine …

    MacOS 10.14.2
    Safari 12.0.2
    Chrome 71.0.3578.98

    Can you let me know what system / browser and versions you are running?

    Thanks,

    Oliver

    Thread Starter Thierry

    (@theremingenieur)

    Since you told me that you couldn’t reproduce the problem on your configuration which is almost identical to mine, I though about possible differences between your system and mine. And I found that you watched the site as a visitor while I watch it while logged in as an admin, having the additional black WP toolbar on top. I logged out, looked at my website as you do and voilà, problem gone.
    Differential diagnose on my iPad: When I’m logged out, everything is fine, but as soon as I log in, I see the same phenomenon on the iPad.

    Then, I went into the user admin section and unchecked the “Show Toolbar when viewing site” option. And again, voilà, problem gone.

    Sorry for having wasted your time. It’s definitively not your plugin but the WP admin toolbar which is the culprit and messes the positioning up.

    Plugin Author Oliver Campion

    (@domainsupport)

    Arha! Well at least I know what the problem is now ??

    The plugin should check for the existence of the admin toolbar. I’ll get a fix sorted in due course and report back.

    Thanks for letting me know.

    Oliver

    Plugin Author Oliver Campion

    (@domainsupport)

    Just pushed an update that will hopefully deal with this issue. Can you check and let me know.

    There is still an issue, however, when clicking on an anchor link from another page. I’m thinking about a css fix ??

    Kind regards,

    Oliver

    Thread Starter Thierry

    (@theremingenieur)

    Yes, thank you, it looks like it fixed it. Have reactivated the admin bar and scrolling works as expected.

    What still doesn’t work correctly, but I guess that’s a different problem, is the scrolling on an iPad in portrait mode when the main menu takes two lines and thus doubles its height. Scrolling does position everything perfectly stable as if there was only one line and as if the main menu had its default height, so that the page title of the corresponding front page section will always been hidden behind the second main menu row.

    Plugin Author Oliver Campion

    (@domainsupport)

    Hmm, I’ve not seen that one but I can imagine what is causing it. Essentially, the height of the menu bar is mitigated with the “scroll to” location by the margin above the titles of the pages.

    So … if you have so many menu items that they are pushing onto two lines on smaller screens then I would highly recommend moving some of the items into sub menus to reduce the number of items in the menu.

    Alternatively, you will need to make the margin above section titles much larger when on screen sizes that push the menu into two lines!

    Oliver

    Thread Starter Thierry

    (@theremingenieur)

    Can’t the scrolling position not be “calculated” from the menu’s bottom? I have only 6 menu items and one language switcher which seems not much to me.

    I’ve already set the margin above section titles to the maximum position of the slider…

    I don’t know what the original 2017 theme designers have smoked but I’d like to understand one day why the div.navigation-top is floating above the div.site-content… ??

    Plugin Author Oliver Campion

    (@domainsupport)

    This is related to the other issue which I’m working on. The one whereby if you are on a page that links to an anchor on another page, it doesn’t scroll to the correct position when the admin bar is present. This is because when you are ON the page with the anchor, javascript can be used to calculate where you need to scroll to. But when you are not already on that page, javascript doesn’t seen to be able to be used.

    In the same regard, yes, we could calculate where to scroll to when on the page, but when not on the page a third part anchor link would still not scroll to the right place.

    So …. I’m working on a CSS solution to take into consideration the admin bar and when landing on an anchor from a third party page which would also remove the requirement for javascript calculation.

    BUT I don’t think this will work for when your menu is doubled up. In this instance you are going to want to avoid doubling your menu up as much as you can be it with less menu items or by reducing the font size / padding / margin of menu items … ?

    We had a similar problem on this site which we solved through a combination of hiding the email and phone numbers and logo as the screen size becomes smaller and can no longer accommodate the menu items.

    Hope that helps in some way? Not ideal I know! Sorry!

    Kind regards,

    Oliver

    Plugin Author Oliver Campion

    (@domainsupport)

    Hi,

    Just re-visiting this loose end.

    I have added some CSS today to make it so that when you link to an anchor tag from a different page it goes to the correct position. I’ve also added a bit of JS to make it scroll to the correct location no matter the height of the menu or presence of the admin bar.

    Take a look and let me know what you think.

    It’s not yet perfect, however …

        If you link to an anchor tag from another page then click on another anchor tag on the same page then back to the original anchor tag, the JS scrolls too far back up the page.
        If the height of the navigation bar has been changed from the default 85px, links from other pages to the anchor will not land in the correct location

    Oliver

    Plugin Author Oliver Campion

    (@domainsupport)

    OK, I think this is finally dealt with. Marking as resolved now but will monitor this thread in case anyone finds any further problems on this topic.

    Oliver

Viewing 14 replies - 1 through 14 (of 14 total)
  • The topic ‘What happened with the scrolling ???’ is closed to new replies.