• Resolved vengen

    (@vengen)


    Not sure how far the statement about Avada being supported, so the following could be a feature request or a bug report.

    I just noticed that images that are in Fusion Sliders aren’t being delivered as webp when I ran my frontpage through pingdom.

    Other images on the frontpage are delivered as webp versions, so that’s groovy. Just not the images in the Fusion Sliders.

    Should that be supported? Is it a bug?

    The images for the sliders are the largest images, so are more important to be optimised, so I’m also keen to find out if there’s something I could do on my end to ensure the webp versions are used.

    Got the latest version of the plug-in installed (2.2.0.2).

    The page I need help with: [log in to see the link]

Viewing 15 replies - 16 through 30 (of 30 total)
  • Plugin Support Hai Zheng?

    (@hailite)

    Can you turn debug log to advanced and see what it says when you load that page?

    Thread Starter vengen

    (@vengen)

    Snippet from debug log: https://pastebin.com/6HXtWak0

    For some reason, it doesn’t find the WebP version of the slider image, unless I read the log wrongly.

    The file is there: https://ephemeralenergy.com/various/webp-20180410-1742.png

    Any ideas?

    Plugin Support Hai Zheng?

    (@hailite)

    Your log helps. We just improved the compatibility for your situation.

    Please try this commit:
    https://github.com/litespeedtech/lscache_wp/commit/451dd095b1386f8a4034199b34682fba6297f8bf

    Thread Starter vengen

    (@vengen)

    Thanks, that did help ??

    Still two related issues, which I can now describe a bit more.

    When I enabled the debugging, I noticed that no debugging appeared in the log for visiting the front page. So none of the slider images there still get served as WebP. However, if I visit any other page, then logs are generated and WebP is served for the slider images.

    With respect to the logo. If you look at the complete log entry for a page visit (below), you can see that there’s nothing in it for the 800px retina logo that gets served as a normal PNG in the end. The log picks up the 400px non-retina logo and carries on serving that as WebP.

    https://pastebin.com/Xwuab0cM

    I don’t know if that helps with the debugging?

    Plugin Support Hai Zheng?

    (@hailite)

    Can you clear the log and paste a new one just generated when you do a new visit? I can’t find 800px you mentioned. Can you tell the source?

    Thread Starter vengen

    (@vengen)

    Well, that’s the thing. There’s nothing in the log about the 800px logo. But that’s what gets served. See this screenshot: https://ephemeralenergy.com/various/webbp-20180410-1942-logo.png

    The log only picks up the default (not retina) logo – /uploads/2018/03/ephemeral-energy-logo-wide-cloud-black-RGB-400px.png

    Plugin Support Hai Zheng?

    (@hailite)

    If it is from retina_logo_url, it won’t be changed. We didn’t parse that attribute yet

    Thread Starter vengen

    (@vengen)

    Ok. Any ideas why the front page doesn’t seem to be parsed properly (and doesn’t appear in the debug log)? The slider images that are served as WebP on other pages are served as JPG on the front page, but the other images further down on the front page that are lazy loaded do get served as WebP.

    https://ephemeralenergy.com/various/webbp-20180410-2010-frontpage.png

    • This reply was modified 6 years, 10 months ago by vengen.
    Thread Starter vengen

    (@vengen)

    WebP served on the front page as well this morning, after having updated the plugin ??

    I don’t know if there was something else included in that plugin update, or if the update process triggered a purge of the cache on the front page that hadn’t happened yesterday evening, though I had purged all, including cloudflare and browser.

    Anyway, thank you very much for the quick support and I guess the next update will include parsing of the retina logo attributes ??

    Plugin Support Hai Zheng?

    (@hailite)

    retina is done. Even if there is any other specific attributes.

    The fix is in https://github.com/litespeedtech/lscache_wp/commit/c9c3b3d56f09ef4d144dd76d96548e9e2b34cd5e

    Thread Starter vengen

    (@vengen)

    Thank you for the update.

    I have done some testing and unfortunately the logo is still served as a PNG, despite the debug log having picked it up and I see log statements about replacements occurring.

    https://pastebin.com/dSAK72qn

    Any ideas?

    Plugin Support Hai Zheng?

    (@hailite)

    Checking your source code, see retina is changed:

    
    <img data-lazyloaded="1" src="https://www.xxx.com/wp-content/uploads/2018/03/ephemeral-energy-logo-wide-cloud-black-RGB-400px.png.webp" data-src="https://www.xxx.com/wp-content/uploads/2018/03/ephemeral-energy-logo-wide-cloud-black-RGB-400px.png.webp" data-srcset="https://www.xxx.com/wp-content/uploads/2018/03/ephemeral-energy-logo-wide-cloud-black-RGB-400px.png 1x, https://www.xxx.com/wp-content/uploads/2018/04/ephemeral-energy-logo-wide-cloud-black-RGB-800px.png 2x" width="400" height="207" style="max-height:207px;height:auto;" alt="Ephemeral Energy Logo" retina_logo_url="https://www.xxx.com/wp-content/uploads/2018/04/ephemeral-energy-logo-wide-cloud-black-RGB-800px.png.webp" class="fusion-standard-logo loaded" srcset="https://www.xxx.com/wp-content/uploads/2018/03/ephemeral-energy-logo-wide-cloud-black-RGB-400px.png 1x, https://www.xxx.com/wp-content/uploads/2018/04/ephemeral-energy-logo-wide-cloud-black-RGB-800px.png 2x" data-was-processed="true">
    

    In your log, ephemeral-energy-logo-wide-cloud-black-RGB-400px.png is searched and replaced twice because you have two in <a class="fusion-logo-link". That is correct.

    The issue is srcset is not changed. Need to do more debug to see when generate images in that log’s srcset, it didn’t trigger WP’s wp_calculate_image_srcset hook (All those which go through that hook will be replaced to webp by us).

    • This reply was modified 6 years, 10 months ago by Hai Zheng?.
    Plugin Support Hai Zheng?

    (@hailite)

    Checked Avada’s code. Found the reason. Their srcset for log is not generated within WP’s stuff but manually did that in includes/class-avada-images.php line 237 get_logo_image_srcset(). Need to work with them to figure out what is a better way to handle this case.

    Thread Starter vengen

    (@vengen)

    Ok, thank you for investigating and good job locating the issue ??

    Plugin Support Hai Zheng?

    (@hailite)

Viewing 15 replies - 16 through 30 (of 30 total)
  • The topic ‘Webp support for Avada Fusion Sliders’ is closed to new replies.