Version 3.26.* forcibly changed my button styles.
-
I did not intend to forcibly add <br>between buttons. After updating to version 3.26.0 or 3.26.1, your plugin keeps automatically adding <br>. Is there any way to disable this automatic addition of <br> tags?
Versions 3.26.* and later
Versions before 3.26.*
-
Upgrade to version 3.6.2 not only forces a line break in the shopping cart but also causes line breaks between the
lielements and icons in themy-accountsection. Please conduct thorough testing before releasing updates and avoid forcing changes that break user styles.
Is there an option in the new version to disable the forced line breaks for these elements?
3.25.* Normal version
@miloss84
I have confirmed that versions before 3.25.* are fine. After updating to 3.26, you automatically insert<br>tags into certain HTML elements, such as between two buttons, or between<i>and<a>, as well as between<label>and<input>. Would it be possible to remove the automatic addition of<br>tags in future versions? Otherwise, it will disrupt the layout design we have created.
Two buttons-Layout break(3.26.4)
Two buttons-Normal(3.25.11)
<i>and<a>-Layout break(3.26.4)
<i>and<a>-Normal(3.25.11)
<label>and<input>-Layout break(3.26.4)
<label>and<input>-Normal(3.25.11)
@richardk23 The interesting part is that before version 3.25.*, your versions were working fine, so I’m not sure which change caused this incompatibility. It definitely happens with WooCommerce buttons and links. I also tested it just now and found that the text within the links is automatically adding
<br>.The theme I am using is: Envo eCommerce, version: 1.2.1
WooCommerce version: 9.5.1
Cart shortcode provided(woocommerce/templates/cart/cart.php):
add <button type=”submit” class=”button” name=”clear_cart”>clear_cart</button><?php do_action( 'woocommerce_cart_contents' ); ?>
<tr>
<td colspan="6" class="actions">
<?php if ( wc_coupons_enabled() ) { ?>
<div class="coupon">
<label for="coupon_code" class="screen-reader-text"><?php esc_html_e( 'Coupon:', 'woocommerce' ); ?></label> <input type="text" name="coupon_code" class="input-text" id="coupon_code" value="" placeholder="<?php esc_attr_e( 'Coupon code', 'woocommerce' ); ?>" /> <button type="submit" class="button<?php echo esc_attr( wc_wp_theme_get_element_class_name( 'button' ) ? ' ' . wc_wp_theme_get_element_class_name( 'button' ) : '' ); ?>" name="apply_coupon" value="<?php esc_attr_e( 'Apply coupon', 'woocommerce' ); ?>"><?php esc_html_e( 'Apply coupon', 'woocommerce' ); ?></button>
<?php do_action( 'woocommerce_cart_coupon' ); ?>
</div>
<?php } ?>
<button type="submit" class="button" name="clear_cart">clear_cart</button>
<button type="submit" class="button<?php echo esc_attr( wc_wp_theme_get_element_class_name( 'button' ) ? ' ' . wc_wp_theme_get_element_class_name( 'button' ) : '' ); ?>" name="update_cart" value="<?php esc_attr_e( 'Update cart', 'woocommerce' ); ?>"><?php esc_html_e( 'Update cart', 'woocommerce' ); ?></button>
<?php do_action( 'woocommerce_cart_actions' ); ?>
<?php wp_nonce_field( 'woocommerce-cart', 'woocommerce-cart-nonce' ); ?>
</td>
</tr>
<?php do_action( 'woocommerce_after_cart_contents' ); ?>Links also break into new lines, screensho-Layout break(3.26.4)t:
Links also break into new lines, screensho-Normal(3.25.11)
Additional information: We will also check the PHP encoding (big5, utf-8), whitespace characters, newline characters, etc., as we have already checked other plugins. The issue only occurs after upgrading your plugin to version 3.26.*.
@richardk23 I just tested and found that the cause of the issue is that the PHP code triggers a line break, which automatically generates a
<br>tag. However, manually deleting all the line breaks would affect the readability of the code. I am still looking into other possible ways to resolve this issue!eg.woocommerce/templates/cart/proceed-to-checkout-button.php
<?php
//Original code
/**
* Proceed to checkout button
*
* Contains the markup for the proceed to checkout button on the cart.
*
* This template can be overridden by copying it to yourtheme/woocommerce/cart/proceed-to-checkout-button.php.
*
* HOWEVER, on occasion WooCommerce will need to update template files and you
* (the theme developer) will need to copy the new files to your theme to
* maintain compatibility. We try to do this as little as possible, but it does
* happen. When this occurs the version of the template file will be bumped and
* the readme will list any important changes.
*
* @see https://woocommerce.com/document/template-structure/
* @package WooCommerce\Templates
* @version 7.0.1
*/
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}
?>
<a href="<?php echo esc_url( wc_get_checkout_url() ); ?>" class="checkout-button button alt wc-forward<?php echo esc_attr( wc_wp_theme_get_element_class_name( 'button' ) ? ' ' . wc_wp_theme_get_element_class_name( 'button' ) : '' ); ?>">
<?php esc_html_e( 'Proceed to checkout', 'woocommerce' ); ?>
</a><?php
//Modified code
/**
* Proceed to checkout button
*
* Contains the markup for the proceed to checkout button on the cart.
*
* This template can be overridden by copying it to yourtheme/woocommerce/cart/proceed-to-checkout-button.php.
*
* HOWEVER, on occasion WooCommerce will need to update template files and you
* (the theme developer) will need to copy the new files to your theme to
* maintain compatibility. We try to do this as little as possible, but it does
* happen. When this occurs the version of the template file will be bumped and
* the readme will list any important changes.
*
* @see https://woocommerce.com/document/template-structure/
* @package WooCommerce\Templates
* @version 7.0.1
*/
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}
?>
<a href="<?php echo esc_url( wc_get_checkout_url() ); ?>" class="checkout-button button alt wc-forward<?php echo esc_attr( wc_wp_theme_get_element_class_name( 'button' ) ? ' ' . wc_wp_theme_get_element_class_name( 'button' ) : '' ); ?>"><?php esc_html_e( 'Proceed to checkout', 'woocommerce' ); ?></a>@richardk23 I am currently keeping the latest version, along with the page where the button is being forcibly appended with
<br>, for your investigation. The URL is as follows: https://test3.lugeshop.com/cart/?add-to-cart=693
I found the problem! Previously, the content editor supported shortcodes, and older pages were built using the following format (A). Currently, you need to switch to using shortcodes (B) to avoid auto-modified partial code.
After upgrading to version 3.26.*, all content using shortcodes must be switched to the shortcode format in the content editor to function properly. I have fixed the issue with the line breaks in the<li>elements on the member login page!<A>
<p>[woocommerce_cart]<!-- /wp:shortcode --></p>
<b>
[woocommerce_my_account]
- You must be logged in to reply to this topic.
