Version 1.5.3
-
Hi
First of all, thx for your work.
About the new version, some issues:1.- Need to state in the change log that hints must be deleted and saved again because the new version stores the headers strings in the db, if not re-saved no headers are sent
2.- Fonts (woff,woff2.. files) must have the crossorigin attribute always not only when they come from google fonts, included self-hosted fonts. I have solved this including my 2nd. domain in the if in the check_for_crossorigin function in the class-gktpp-insert-to-db.php file. I have not tested if not using these function. I have to set a if, to test if the hint is a font to not include the crossorigin in others hints.
3.- The values of as and type must be double quoted (as=”font”;type=”font/woff2″) so I have changed these lines
$header_as_attr = " as=\"$as_attr\";"; $header_type_attr = " type=\"$type_attr\";";
4.- This line is wrong:
$header = "<$url>; rel=$hint_type;$header_as_attr$
head_type_attr$header_crossorigin";
must be:
$header = "<$url>; rel=$hint_type;$header_as_attr$header_type_attr$header_crossorigin";
- The topic ‘Version 1.5.3’ is closed to new replies.