• Resolved Mike

    (@suchaqd)


    Hi Ricard! Love the plugin =) Any chance on updating it to get rid of the jQuery dependency any time soon? Thanks for developing it and keep up it with your podcast!

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Ricard Torres

    (@quicoto)

    Hey Mike,

    You’re absolutely right. We should remove it but then we need to consider what browsers are we supporting.

    If we’re using the fetch API https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API we either drop IE11 support or add something like Axios to make it more heavy https://github.com/axios/axios

    I think we could take the decision to move it to fetch, those who need the jQuery version can still use 3.4.2 version of the plugin.

    We can also use the new ES6 syntax, again we could drop support and not transpile anything.

    Alright, I’ll start looking and update this thread once I have something to share.

    Plugin Author Ricard Torres

    (@quicoto)

    Hello Mike,

    I have released version 4.0.2 dropping the jQuery dependency.

    Have a look, give it a try, and let me know!

    Thread Starter Mike

    (@suchaqd)

    Wow, that was super fast! Very much appreciated!! Tested out the update and only encountered a minor snag. There is some jquery injected into the page through thumbs-rating.php around line 253, which checks for the already voted state. Removing that function still enables the ratings to record, but also leaves out the “You already voted!” message to the user. Otherwise, all worked as expected =)

    Plugin Author Ricard Torres

    (@quicoto)

    Thank you, Mike. Good catch.

    The theme I was testing on already had jQuery so I didn’t see any undefined.

    I removed that piece of jQuery as it was doing nothing. The class “voted” was already being added via PHP. This jQuery was redundant.

    Please upgrade to 4.0.3 and let me know

    Thanks!

    Thread Starter Mike

    (@suchaqd)

    Perfect! Thank you so much again for the quick updates and speedy replies! =)

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Vanilla JS version in roadmap?’ is closed to new replies.