• Resolved leoquijano

    (@leoquijano)


    Hi,

    After installing version 3.0.4, the checkout button breaks. The cause is broken Javascript. I’m using Ubuntu Firefox 49.0

    The bug is in the following 2 files:

    assets/js/stripe_checkout.js
    assets/js/stripe_checkout.min.js

    Please see my patch below. It also needs to be applied to the minified version:

    --- a/site/wp-content/plugins/woocommerce-gateway-stripe/assets/js/stripe_checkout.js
    +++ b/site/wp-content/plugins/woocommerce-gateway-stripe/assets/js/stripe_checkout.js
    @@ -42,20 +42,21 @@ jQuery( function( $ ) {
                            // Don't open modal if required fields are not complete
                            if ( $( 'input#terms' ).length === 1 && $( 'input#terms:checked' ).length === 0 ) {
                                    return false;
                            }
     
                            if ( $( '#createaccount' ).is( ':checked' ) && $( '#account_password' ).length && $( '#account_password' ).val() === '' ) {
                                    return false;
                            }
     
                            // check to see if we need to validate shipping address
    +                       var $required_inputs;
                            if ( $( '#ship-to-different-address-checkbox' ).is( ':checked' ) ) {
                                    $required_inputs = $( '.woocommerce-billing-fields .validate-required, .woocommerce-shipping-fields .validate-required' );
                            } else {
                                    $required_inputs = $( '.woocommerce-billing-fields .validate-required' );
                            }

    Note that the $required_inputs variable is not correctly declared. Can you please include this in v3.0.5. This is a critical bug.

    Thanks,

    Leo

    • This topic was modified 8 years, 5 months ago by leoquijano.
Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Contributor royho

    (@royho)

    Please download the file again and re-test.

    Verifying that I’m seeing what appears to be the same problem. I filed an issue over at the extension’s Github repository.

    Sorry, @royho, our posts crossed. I just downloaded it again and it did fix the problem.

    For others who may be dealing with this, you may also need to have customers who ran into the problem refresh the page or clear their browser’s cache before it works.

    Plugin Contributor royho

    (@royho)

    No worries, also I deployed 3.0.5 so not to confuse people. Been having issues with my deploy script missing file updates today…not sure why…

    • This reply was modified 8 years, 5 months ago by royho.
    Thread Starter leoquijano

    (@leoquijano)

    Thanks for the quick update @royho

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘v3.0.4 breaks checkout button “DEVELOPERS: xxx”’ is closed to new replies.