v2.0.0-2.1.0 jQuery Dependency Issue

  • Resolved cdbtech

    (@cdbtech)


    4 years, 10 months ago

    Hi,

    v2.0.0 registers a jQuery dependency for https://cdn.onesignal.com/sdks/OneSignalSDK.js. This is breaking notifications on our site, since we’ve deregistered jQuery on the frontend entirely.

    The problematic line is on onesignal-public.php:61, where array(‘jquery’) should just be an empty array.

    v1.17.9 does not have this issue on the comparable line onesignal-public.php:94.

    My guess is a developer (correctly) switched to using the WP enqueue system, but either copy/pasted a wp_register_script() example with jQuery in it, or didn’t think about dependencies.

    If you examine the script itself on https://cdn.onesignal.com/sdks/OneSignalSDK.js, you’ll see that jQuery is not required. Please remove the dependency so that we can upgrade to v2.x

    Thank you

  • The topic ‘v2.0.0-2.1.0 jQuery Dependency Issue’ is closed to new replies.