Using legacy jQuery UI v1.13.2 breaks tabs from other plugins

  • Resolved flowdee

    (@flowdee)


    1 month ago

    Hey @gregross!

    We experienced, that since we use your plugin, the tab UI from our own (and other) plugins is broken.

    Here’s what it looks like when your plugin is active:

    This is how it should look:

    It looks like your loading legacy jQuery UI v1.13.2 instead of using v1.13.3 which is also included in WP core.

    I am not sure why you load your own, instead of making use of what is it in core, but this should be fixed, please.

    Besides that, it would be great if you only load your assets on the actual post types where it’s needed and not around all the admin area. ??

    Thanks in advance!

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Greg Ross

    (@gregross)

    The plugin doesn’t specify the version of jQuery UI to use, it lets WP decide that by specifying it as a dependency only.

    On my dev box and several production boxes I checked and 1.13.3 is being loaded, none of them have 1.13.2… perhaps something specific to your install? Have you tried disabling all other plugins and made sure to flush your browser cache?

    Limiting the load to only the JWS pages makes sense and is easy enough to add though, so I’ll do so for the next release. Can you verify as above though none the less? Thanks.

    P.S. Your images didn’t come through but I assume it’s messed up ??

    Thread Starter flowdee

    (@flowdee)

    You are delivering and loading an outdated version of jQuery UI css from your plugin, which is totally unnecessary and breaks things: https://github.com/toolstack/just-writing-statistics/blob/edc8c4008f0849daf0a9acf35769bad8f17efcf5/admin/class-jws-admin.php#L101

    View post on imgur.com

    Please just use what’s in core already: https://wordpress.stackexchange.com/a/273996

    • This reply was modified 1 month ago by flowdee.
    Plugin Author Greg Ross

    (@gregross)

    Ah, you mean the css file, that’s required for the datepicker, as that part of the css isn’t included in the base WP style sheets.

    Reducing the scope of the css/js loads to just the JWS pages should resolve this and I’ll update the style sheet as well to the newer version.

    Plugin Author Greg Ross

    (@gregross)

    I’ve release version 5.3 which limits the loading of the css/js to only the JWS pages, so this should resolve the issue for you.

    Thread Starter flowdee

    (@flowdee)

    At least something, thanks ??

Viewing 5 replies - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.

Tags