User-friendly username

Not sure about this one. Let’s see what others say.

Regards

At the end I changed it a bit. Check new version

Not exactly what I meant. I still have concerns that the generated username will not necessarily be unique and the user will not be able to do anything to fix that.

However, it can be customized easily thru the fbl/user_data_login filter. I will post my solution if I figure out how to garantee uniqueness in an efficient way.

I know, this is ugly and should not be integrated as-is but I meant someting like this:

add_filter( 'fbl/user_data_login', 'fbl_ext_user_data_login' );
function fbl_ext_user_data_login( $user ) {
	global $wpdb;

	if( !empty( $user['user_email'] ) ) {
        $user['user_login'] = strtolower( explode( '@', $user['user_email'] )[0] );
    }
	elseif( !empty( $user['first_name'] ) || !empty( $user['last_name'] ) ) {
		$user['user_login'] = strtolower( "{$user['first_name']}.{$user['last_name']}" );

		// replace regional characters
		$user['user_login'] = iconv( 'UTF-8', 'ASCII//TRANSLIT//IGNORE', $user['user_login'] );
	}
	elseif( !empty( $user['fb_user_id'] ) ) {
		$user['user_login'] = $user['fb_user_id'];
	}
	else {
		$user['user_login'] = floor( 1000 * microtime( true ) );
	}

	// remove special characters
	$user['user_login'] = trim( preg_replace( '/[^a-z0-9]+/', '.', $user['user_login'] ), '.' ); 

	// "generate" unique suffix
	$suffix = $wpdb->get_var( $wpdb->prepare(
		"SELECT 1 + SUBSTR(user_login, %d) FROM $wpdb->users WHERE user_login REGEXP %s ORDER BY 1 DESC LIMIT 1",
		strlen( $user['user_login'] ) + 2, '^' . $user['user_login'] . '(\.[0-9]+)?$' ) );

	if( !empty($suffix) ) {
		$user['user_login'] .= ".{$suffix}";
	}

	return $user;
}

Also, I understand that this plugin always requires email from facebook so the long if-then-else chain does not make sense in this form. I was just playing around with different options.

Btw, currently this calculation runs every time someone uses facebook to login/register. It would make more sense to run this only when we need to create a new user.

What do you think about this:

private function generateUsername( $user ) {
		global $wpdb;

		if( !empty( $user['first_name'] ) && !empty( $user['last_name'] ) ) {
			$username = strtolower( "{$user['first_name']}.{$user['last_name']}" );
			// replace regional characters
			$username = iconv( 'UTF-8', 'ASCII//TRANSLIT//IGNORE', $username );
		} else {
			// use email
			$email    = explode( '@', $user['user_email'] );
			$username = strtolower( $email[0] );
		}

		// remove special characters
		$username = trim( preg_replace( '/[^a-z0-9]+/', '.', $username ), '.' );

		// "generate" unique suffix
		$suffix = $wpdb->get_var( $wpdb->prepare(
			"SELECT 1 + SUBSTR(user_login, %d) FROM $wpdb->users WHERE user_login REGEXP %s ORDER BY 1 DESC LIMIT 1",
			strlen( $username ) + 2, '^' . $username . '(\.[0-9]+)?$' ) );

		if( !empty( $suffix ) ) {
			$username .= ".{$suffix}";
		}

		return $username;
	}

I changed it a bit and refactored for php5.3 . sadly a lot of users are using old versions, even 5.2.

Emails exist or the function is never reached so I guess we can use first and lastname if exist and if not simple the email part.

Havent tested the suffix query, I trust you in that way ??

Unfortunately, this upgrade did not work out well to me. The “iconv” piece turned out to work only on my local server but not on the remote host. It converts all strange characters to questionmarks (instead of the “base” character, e.g. á->a). It requires a setlocale(LC_CTYPE, ‘en_US.UTF8’) (or some other utf8 locale) in front of it but I’m not sure how that can be globalized. (WP has a get_locale() function but it does not necessarily use utf8 and it did not solve the problem on my remote host)

At the same time, I have entirely lost control over the user_login field. I used filters to customize it, but with the new code there is no filter to leverage.

Sorry for keep complaining. I still like your plugin.

Don’t worry , plugins get stronger with feedbak like this. When I tested locally also worked. Instead I will use a function that is default from wordpress called sanitize_user

What I don’t understand is what control you lost If I didn’t remove any filter.

It is related to the optimization (i.e. not calculating username for every login any more). I used to leverage the fbl/user_data_login filter to override the user_login field but now the filter is applied before the generateUsername call. Also, there is no hook/filter currently in between the following lines to override the canned calculation:

$user['user_login'] = $this->generateUsername( $fb_user );
$user_id = $this->register_user( $user );

Gotcha, I will add a couple of filters there so you can use