Viewing 12 replies - 1 through 12 (of 12 total)
  • Plugin Author nosilver4u

    (@nosilver4u)

    That link didn’t work, what plugin are you actually using?

    Thread Starter joeymalek

    (@joeymalek)

    Plugin Author nosilver4u

    (@nosilver4u)

    At this point, that plugin is uploading the images after the resizes have been optimized (if you’re using WP 3.5+), but before the full size has been optimized. The author uses the same hook as I do, but he runs at priority 20, while I run at 60. We have two options:

    @bradt

    1. The Amazon S3 author can bump his up to something higher than 60
    2. I can drop mine to something lower than 20.

    I chose 60 only to make sure that I was running after any other plugin that might be making edits using that same hook, but I don’t know of any actual plugin that uses a priority higher than 10 that is of any concern.

    I don’t mind making the change, but I’ll defer to bradt as to whether he has any objections to changing his priority level for the ‘wp_generate_attachment_metadata’ hook.

    Thread Starter joeymalek

    (@joeymalek)

    Hello guys I really appreciate what you are doing now. My hat is off. You are changing the internet for a better place.
    (any news of the Imsanity author I alerted of the same ?)

    Plugin Author nosilver4u

    (@nosilver4u)

    From my testing, Imsanity works just fine, since it runs before my hooks. Basically, the way it needs to run is like so:

    1. Any plugin that edits or modifies the images runs first
    2. Image Optimization
    3. Uploading to cloud services (like Amazon S3)

    Plugin Author nosilver4u

    (@nosilver4u)

    Should also mention that part of the reason Imsanity works (if memory serves me correctly), is because I also hook onto the wp_image_editor class, so when plugins like Imsanity generate their images, they are auto-optimized. This is why the resizes are optimized before the Amazon S3 plugin uploads them, but the original doesn’t get modified or edited by default, so it doesn’t get optimized until after the Amazon S3 upload takes place.

    Hope that all makes some sense.

    Thread Starter joeymalek

    (@joeymalek)

    Alright got that. Good to see you in such a good sync.
    I have just seen an update to your plugin on one of my site was this one here ?

    Plugin Author nosilver4u

    (@nosilver4u)

    I released the update this morning, so I won’t be doing another update until for at least a week. Once I hear from bradt, the changes can be made in dev, and you can download that at anytime from the Developers tab.

    Thread Starter joeymalek

    (@joeymalek)

    Thanks a lot you are doing a fantastic job !!!

    Sure, I don’t see why I can’t bump up the priority to 100. Can one of you add this to GitHub: https://github.com/bradt/wp-tantan-s3/issues ?

    Thread Starter joeymalek

    (@joeymalek)

    Fantastico Brad (marvelous piece of plugin you got there). Can nosilver4u https://www.shanebishop.net/ do this bump please ?

    Plugin Author nosilver4u

    (@nosilver4u)

    joey, I think you misunderstood. If Brad is bumping his to 100, I don’t need to change anything. He does, however, need one of us to create a ticket for him, so I will go ahead and do that.

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘usability question’ is closed to new replies.