Undefined variable: str in wp-sitemap-page.php

Hello,

In PHP 8.0.12 it is a warning:
PHP Warning: Undefined variable $str in /wp-content/plugins/wp-sitemap-page/wp-sitemap-page.php on line 477

Hello,

I have the same!
That it is a simple warning, I am okay, but for the Net surfer it is not very pretty.
Does anyone know how to get rid of it?

thanks in advance

From the looks of it, lines 476 and 477 were copied from the above function on line 276 and 277, along with the rest of the array creation.

As the $str variable on line 477 isn’t being used at all in that function, it could be commented out until the plugin is updated.

In fact, since wsp_wp_sitemap_page_main_func() filters the shortcode content using wsp_wp_sitemap_page_func(), lines 476-507 seem completely unnecessary.

Commenting them out seems to be working OK.

@funnycat, can you please release a fix for this?

• This reply was modified 3 years ago by Gal Baras.
• This reply was modified 3 years ago by Gal Baras.

Thank you all for your help.
Commenting out lines 476 to 507, I have a different error message!
Undefined variable $arr in /home/clients/23a0cf32c5b47c75c78ccdc7c193c655/web/wp-content/plugins/wp-sitemap-page/wp-sitemap-page.php on line 512
I leave aside for now, hope for a fix in the near future.

Sorry, I forgot to check the error log.

Yeah, the last line in wsp_wp_sitemap_page_main_func() (line 509, actually) should be this:

return '<div class="wsp-container">' . wsp_esc_some_html_tags( wsp_wp_sitemap_page_func( $atts, $content ) ) . '</div>';

This time, the log is clean and the page appears to be correct.

BTW, this could be caused by using the E_STRICT PHP error reporting flag. PHP doesn’t have any problems with undefined variables. It assumes they’re empty, casts them to the expected type and keeps going. But if strict error reporting is enabled, it reports them, although there are no execution problems.

Thanks a lot Gal, the problem is solved with your valuable advice.

Well, @funnycat should still release this fix for everyone to enjoy. Unfortunately, the respective code still looks the same in 1.9.0 ??

This is what I note with regret this morning…

Yep, I get the same errors.

Hello everybody.
Thank you for these messages to let me know about this error. I just released a fix (version 1.9.1). Sorry about this mistake.
Have a really nice day.
Sincerely,
Tony

Great! Many thanks @funnycat

@funnycat

Thank you Tony for the update, I fixed it myself, but glad you finally caught up with it.

Thank you so much Tony