• Resolved muppix

    (@muppix)


    Heads-up @ndiego: there’s a PHP error in includes/frontend/visibility-tests/hide-block.php:44 because hideBlock isn’t always available as an index of $attributes. Right now for me $attributes is a single element array containing [visibilityByRole] => logged-in. Test for presence of index before evaluating?

    Great work on this plugin BTW, it’s well implemented and does exactly what I need. Kudos!

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Nick Diego

    (@ndiego)

    Thanks for catching this @muppix! Somehow I have not seen this error in my testing. I will investigate straight away and will followup once I have diagnosed the issue.

    Also, I really appreciate the review!

    Best,
    Nick

    Thread Starter muppix

    (@muppix)

    No worries Nick, glad I could help. Another great plugin is Query Monitor – helps me catch the occasional error in my own code… ??

    Plugin Author Nick Diego

    (@ndiego)

    Great tip on Query Monitor, just installed and very useful!

    I fixed the issue, dumb oversight on my part, and have pushed a fresh release with a fix.

    Thanks again for the kind review!

    Nick

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Undefined index: hideBlock’ is closed to new replies.