Unclosed Tag

Hello @oganianarman,

Thank you for getting in touch with us!

This tag is closed in the footer.php of each theme. For example – the footer.php of twentynineteen – https://github.com/WordPress/twentynineteen/blob/master/footer.php#L16.

I hope this helps. Please let me know if you are facing issues.

Regards,
Prajakta

Hey Prajakta,

1. But in your default footer there isn’t any closing tag,it means using your default header and footer,I will get broken html?

2. What if a theme is using in the header multiple div like this <div id=”a”><div div=”b”><div id=”c”> ,it means in the footer there are 3 divs and using only header without or only footer without header, the html can be completly broken

Hey Prajakta,

do you have an idea how to fix it?

Hello @oganianarman,

My sincere apologies for the delay in response!

I had a look into this. In the case of global theme support, we replace the theme’s header.php and footer.php by the hfe-header.php and hfe-footer.php from EHF.

However, we had missed closing the opened <div> tag in hfe-footer.php. Thank you for bringing this to us!

We have fixed this issue in the PR — https://github.com/Nikschavan/header-footer-elementor/pull/320 for which an update will be shipped soon.

We will surely inform you once this fix will be available with the upcoming releases of EHF.

Regards,
Prajakta

Hey Prajakta,

Thanks for reply. I saw commit nn guthub only the fixed of 1,but I didn’t see the fix related 2 or it hasn’t been fixed yet?

Hello @oganianarman,

Thank you for getting back to us!

Every theme has a single ‘div’ tag kept open in the header to be closed in the footer.php. Every other ‘div’ should be closed in the header.php file only. We do not have any color over this case.

If the theme has more than 1 open ‘div’ in the header then it is the responsibility of the theme author to close them in the header.php only. In EHF’s footer.php, we will close only the main ‘div’.

I hope this explanation helps. Please let me know if you have any queries.

Hey again

I think you don’t understand what I mean.

Let’s say I have a theme

1. header file is <div id=”a”><div id=”b”><div id=”c”>
2. footer file is </div></div></div>

Everything is correct in my theme? yes!

now I am using your plugin and only changing header of my theme,but leaving the footer to load from theme. What I will get 2 unclosed tags. The same if I will use only footer but will leaving the header to load from theme.

Your plugin will not corrupt the page ONLY when I will use both header and footer together.

Hello @oganianarman,

Apologies for the delay in response due to the weekend off!

We have two methods for the theme support —
1) Replaces theme’s header and footer template with EHF’s templates
2) Hides the theme’s header and footer with CSS and displayes content from EHF using WordPress hooks.

For method 1, we can handle only one closing tag as most of the themes have only the main div tag kept open to be closed in the footer. But, for a particular case like in the case of your theme, you can choose method 2 which will just hide the header of your theme with CSS and will display the content from EHF.

Ideally, it is expected that every opened tag in the header will be closed in the header itself by the theme author, however, if this is not done, then choosing method 2 is preferable.

In this way, if the theme has the header or footer markup other than the standard, then hiding only the content from the theme with CSS will help.

I hope this explains. Please let me know if you have further queries.

Regards,
Prajakta

Hey Prajakta,

Thanks for response,but you are kidding me))? what means 1 close tag is standard? it’s your standard? Or maybe because this task is difficult for you and you are popular plugin,that is why themes author HAVE TO integrate the code with your plugin?

FYI: You just need to calculate in the header(opened tags) or footter(closed) tags,it’s difficult task,but possible. Css hiding is bad for SEO.

Hey Prajakta,

Is there any news for this problem?

Hello @oganianarman,

Apologies that I missed replying to you!

I had a discussion regarding this with the other developers. We understand your concern that closing just a single <div> tag may break the HTML if the theme has multiple opened tags in the header.

As of now, as a solution to this, we can add an action to HFE’s hfe-footer.php and hfe-header.php where you can open or close the required tags according to the theme’s HTML.

Please let me know if this is feasible for you so that we can ship this with the upcoming release.

Looking forward to hearing from you.

Regards,
Prajakta Suryawanshi

Hello @oganianarman

I am glad to inform you that HFB version 1.5.4 is released and it includes your feature request.
?
Kindly update to the latest version and let us know your feedback.

Have a great day ahead!

Regards,
Rahul