• Resolved damon.morda

    (@damonmorda)


    Hi folks,

    We’re preparing to upgrade our clients to PHP 7.2 and assessing the compatibility of our plugins with this version of PHP. When we ran our tests on version of Types 2.3.4 we turned up a number of warnings, but no errors.

    I’ve included the warnings below and I was wondering if we could get confirmation of if Types is compatible with PHP 7 and if not, if there was an estimated date when it would be.

    Thanks in advance!

    Name: Toolset Types
    
    FILE: /webroot/wp-content/plugins/types/application/controllers/asset/manager.php
    --------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     44 | WARNING | Method name "Types_Asset_Manager::__initialize_styles" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
     49 | WARNING | Method name "Types_Asset_Manager::__initialize_scripts" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
    --------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/resources/index.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1 | WARNING | No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/includes/fields/time.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1 | WARNING | No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/includes/fields/map.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1 | WARNING | No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/usermeta-init.php
    --------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------------------------------------------------
     188 | WARNING | Function name "__wpcf_usermeta_test" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
    --------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/classes/loader.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------
     120 | WARNING | Method name "WPCF_Loader::__registerScripts" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
     173 | WARNING | Method name "WPCF_Loader::__registerStyles" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
     321 | WARNING | Method name "WPCF_Loader::__toolset" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/classes/validation-cakephp.php
    ---------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ---------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1100 | WARNING | Method name "Wpcf_Cake_Validation::__populateIp" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
     1131 | WARNING | Method name "Wpcf_Cake_Validation::__reset" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
    ---------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/classes/field.php
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------
     760 | WARNING | Method name "WPCF_Field::__get_slug_no_prefix" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/classes/relationship/form-child.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     674 | WARNING | Method name "WPCF_Relationship_Child_Form::__filter_meta_form" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/resources/index.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1 | WARNING | No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/includes/fields/time.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1 | WARNING | No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/includes/fields/map.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1 | WARNING | No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/includes/fields/date/functions.php
    ---------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------------------------------------------------------------
     457 | WARNING | Function name "__wpcf_fields_date_check_leftover" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
    ---------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/includes/fields/twitter.php
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     1 | WARNING | No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/admin.php
    ---------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------
     395 | WARNING | Function create_function() is deprecated since PHP 7.2; Use an anonymous function instead
    ---------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/toolset/types/embedded/views/image.php
    ---------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ---------------------------------------------------------------------------------------------------------------------------------------------------------------
     124 | WARNING | Method name "Types_Image_View::__resizeImg" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
     764 | WARNING | Method name "Types_Cache::__getCacheKey" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
    ---------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/twig/twig/lib/Twig/Lexer.php
    -----------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    -----------------------------------------------------------------------------------------------------------
     87 | WARNING | INI directive 'mbstring.func_overload' is deprecated since PHP 7.2
     91 | WARNING | INI directive 'mbstring.func_overload' is deprecated since PHP 7.2
    -----------------------------------------------------------------------------------------------------------
    
    FILE: /webroot/wp-content/plugins/types/vendor/twig/twig/lib/Twig/Compiler.php
    --------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------
     218 | WARNING | INI directive 'mbstring.func_overload' is deprecated since PHP 7.2
    --------------------------------------------------------------------------------------------------------------
Viewing 3 replies - 1 through 3 (of 3 total)
  • Anonymous User 14808221

    (@anonymized-14808221)

    I see there are mainly 2 types of errors.

    1. Until PHP reserves the exact function names with double underscores as warned, Types as Free version will not exist anymore most likely because it will get removed this end of the year and it’s suggested to look out for other solutions.

    However, I have passed that along to the developers also because of the continued Types version 3.0 where this is as well still an issue.

    2. Even WordPress would not be PHP 7 compatible (check all the “silence is golden” files that the Core Code of WP has) if a simple PHP opening tag is forbidden. Hence I think this is a false alarm.

    But as well here I passed it along for assessment.

    3. The other errors refer to code that is not present anymore in the continued(paid) Types (Toolset) version, and only present in this “to be deprecated” Free Types version.
    I will ask our developers if we will adjust it, however, I think probably not, as it is not a breaking issue until the plugin will stay supported, however, I will let the developers assess this, and then let you know here our plans.

    Anonymous User 14808221

    (@anonymized-14808221)

    I got word from our developers that for the Free Types version there are no plans to adjust this, hence, for the remaining 1,5 months of which Types will remain supported, you would have to turn off error reporting on production sites.

    Later, free Types is to be deprecated and new solutions should be found.

    Thread Starter damon.morda

    (@damonmorda)

    Thanks. I’ve purchased Toolset and will open a separate thread on issues for Toolset 3.1.2.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Types 2.3.4 Compatibility with PHP 7.2’ is closed to new replies.