Trying to add Romanian states

  • Resolved farterazvan

    (@farterazvan)


    4 years, 7 months ago

    Hey, I have an excel with Romanian counties (kind of similar to States) and cities and I want to add them in the according folders. I think I can manage to do it, but I just wanted to let you know. After that I’ll try to make a commit. Maybe you can review and include it into the plugin, to be available for others.

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Yordan Soares

    (@yordansoares)

    Hello @farterazvan,

    That’s awesome! Please sent your commit as soon as you can. If you need help to do it, please read these instructions: Adding a new country

    Thanks in advance for helping us to extend this list adding your country.

    Best regards.

    Thread Starter farterazvan

    (@farterazvan)

    Could you please commit? As I don’t necessarily have the skills with SVN

    I am not sure you are going to like the change though, as the list I added increases the plugin size with 1.5mb

    https://www.dropbox.com/s/mhbsvelxhvwg1ow/states-cities-and-places-for-woocommerce.zip?dl=0

    • This reply was modified 4 years, 7 months ago by farterazvan.
    Plugin Author Yordan Soares

    (@yordansoares)

    Hello @farterazvan,

    What a wonderful job! Before upload this to the next release, I want to ask you some questions:

    1. Is it necessary to add translation feature to Romanian locations? If so, I will add the file as is. If not, we can decrease the filesize removing the translation function from each location.
    2. I noticed you don’t used a key for the Counties of Romania, but the name cities itself. In an unfinished file I have of Counties of Romania I used the codes I found here: ISO 3166-2:RO. Don’t you think would be better to use them instead of city names?
    3. I also noticed that the order of places/RO.php doesn’t match with states.RO.php, can you use the same order in both files?

    Thread Starter farterazvan

    (@farterazvan)

    Sure! Thanks a lot for the review! ??

    1. No, not needed.
    2. Thanks’ for the link!
    3. Sure!

    Today I have more time so maybe I also learn how to make a branch in SVN and push the change.

    https://github.com/chitezh/woocommerce_states_places/tree/master/templates

    Thread Starter farterazvan

    (@farterazvan)

    This time I put only the trunk archive. I hope it looks better. The total size is much better now.
    https://www.dropbox.com/s/ic8duk1w1bo2r5j/trunk.zip?dl=0

    just a heads up,

    For the Capital City, the setup should be like this:

    State: Bucuresti
    City: Sector 1 | Sector 2 | Sector 3 | Sector 4 | Sector 5 | Sector 6

    Currently, with Razvan’s additions, when choosing Bucuresti as state, for the city you get 2 option: Bucuresti | Mun. Bucuresti

    Bucharest is divided into 6 administrative departments, called “Sector” and they are commonly used when addressing mail.

    If you guys can make this addition, this plugin RULES!

    • This reply was modified 4 years, 7 months ago by IonutSabo.
    Plugin Author Yordan Soares

    (@yordansoares)

    Thanks for your feedback @ionutsabo,

    @farterazvan already included your suggestion in the places/RO.php. We planned to include Romania in next release, please stay tuned!

    Best regards.

    Plugin Author Yordan Soares

    (@yordansoares)

    Hello @farterazvan and @ionutsabo,

    I just released the latest version of “States, Cities, and Places for WooCommerce” that adds 5 new countries, Romania included. Please update the plugin to the latest to see your country locations.

    Thanks for your contribution!

    Best regards,
    Yordan Soares

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Trying to add Romanian states’ is closed to new replies.

Tags