Topic and Reply Rules text
-
I write texts in Topic Rules text and Reply Rules text. But on the website, the article I wrote in Topic Rules text appears in both sections.
The page I need help with: [log in to see the link]
-
ok, I can only see one text
Giri? yapmadan konu a?abilir veya cevap yazabilirsiniz. Fakat mesajlar?n?z? daha rahat takip edebilmek i?in giri? yap?n.
- This reply was modified 1 year, 9 months ago by Robin W.
I can replicate this.
In the “Topic/Reply Form” settings tab > #10, click to activate posting rules for both topics and replies.
In the Topics posting rules textarea I put “Test TOPIC rules”
In the Replies posting rules textarea I put “Test REPLY rules”
On the frontend of the site, both new topic form and reply form both show “Test TOPIC rules”. Neither of them show “Test REPLY rules”.
Looking at /includes/settings_topic_reply_form.php where the values are saved and in /includes/functions.php where the values are retrieved/displayed, everything looks fine at first glance. Gonna take a little bit of digging to find the culprit. I did just want to verify that it is a legit bug I can replicate.
thank you…
@metesey – try re-saving that tab, and maybe adjust values. I say that because now it’s working fine for me. I made zero changes to code, but played around with settings clicking save a few times and now it’s working fine for me.
@robin-w – mysterious bug here. I did replicate/verify the bug, but now I can’t replicate it again. Gonna keep digging to see what I can figure out.
I’m able to replicate it consistently now. Reset the settings for Topic/Reply Form, then walk through the initial steps:
In the “Topic/Reply Form” settings tab > #10, click to activate posting rules for both topics and replies.
In the Topics posting rules textarea I put “Test TOPIC rule”
In the Replies posting rules textarea I put “Test REPLY rule”
In Plugin Information, the values saved to the DB for that tab show:
s:16:"topic_rules_text";s:15:"Test TOPIC rule"; s:16:"reply_rules_text";s:15:"Test TOPIC rule";
Refresh the Topic/Reply Form and sure enough, it shows the duplicate “Test TOPIC rule” and “Test REPLY rule” is nowhere to be found.
Manually change the bad value for reply rules back to “Test REPLY rule”, and then it finally saves it properly.
If I reset the settings, I can consistently duplicate the issue. But once settings have been saved and then re-saved, it behaves properly.
Still digging to find the culprit, but at least it’s narrowed down to the initial saving of the options for that tab.
@metesey – Until this is officially fixed, my advice as a temporary work-around still stands: Try re-saving that tab, and maybe adjust values before re-saving.
FYI – I’ve been working on a big update, restructuring the admin settings page. Those changes have fixed this bug. Unfortunately, I can’t release the fix as a simple patch to the existing 5.3.5 release due to the new code being a complete overhaul of how tabs/settings are handled which is not compatible with the current plugin as-is. It’s a complete overhaul that brings all tabs, option groups, and settings fields into a new defined standard that should help prevent any mysterious bugs like this in the future.
@robin-w – don’t worry, all existing plugin settings will work fine and transfer over to the new revision without any issues.
@metesey – I wish I could publish a fix for you sooner, but it will be taken care of in an upcoming release. Sorry for the delay!
@metesey – Releasing a new version today that will fix this bug. v 5.4.2 Figured out a way to do it without having to release a major revision. Sorry for the delay in resolving this for you. Marking this topic as resolved. Let us know if you have any other issues.
@robin-w – 5.4.2 will be release shortly that fixes this issue with a slight performance enhancement in bbp-style-pack.php ( only run plugin field/value conversions once per plugin upgrade instead of on every page load, and only overwrite reply rule if it’s empty ).
It also includes a PhP warning fix, better handling of menus, and alignment corrections for “which menus do you want to show this on” for Login/Logout, Register, and Profile links in the login settings tab (was giving me “undefined array key” issues when no menus defined, or a theme does not specify a distinct “primary” menu).
It also has some minor tweaks to the admin plugin page links and a few extra description links added for “Official Support”, “Donate”, and “Rate Us”.
- The topic ‘Topic and Reply Rules text’ is closed to new replies.