Tooltips in widgets broken in 2.2

Figured out a way to loop through widget data to provide a permanent fix. This will make it still only load scripts when necessary and will only check widget data when not found in post data. The only thing I’m not sure of is if a home page is set to “static,” will “add_filter( ‘the_posts’, array( $this, ‘load_scripts’ ) );” still fire? I assume so. Anyways, here is my fix:

First the function to check the widget data. I inserted this just above the load_scripts function:

public function active_in_widget() {
	global $wp_registered_widgets;
	$active_widgets = get_option( 'sidebars_widgets' );
	foreach ( $active_widgets as $sidebar_name => $sidebar_widgets ) {
		if ($sidebar_name != 'wp_inactive_widgets' && !empty($sidebar_widgets) && is_array($sidebar_widgets)) {
			foreach ($sidebar_widgets as $widget_instance) {
				$widget_class = $wp_registered_widgets[$widget_instance]['callback'][0]->option_name;
				$instance_id = $wp_registered_widgets[$widget_instance]['params'][0]['number'];
				$widget_data = get_option($widget_class);
				if (!empty($widget_data[$instance_id]['text'])) {
					if (stripos( $widget_data[$instance_id]['text'], '[gcal' ) !== false) return TRUE;
				}
			}
		}
	}
	return FALSE;
}

And then the modification to load_scripts:

public function load_scripts( $posts ) {
	$load_scripts = FALSE;

	if ( !empty( $posts ) ) {
		foreach ( $posts as $post ){
			if ( ( strpos( $post->post_content, '[gcal' ) !== false ) || ( $post->post_type == 'gce_feed' ) ) {
				$load_scripts = TRUE;
				break;
			}
		}
	}

	if (!$load_scripts) {
		if ($this->active_in_widget()) $load_scripts = TRUE;
	}

	if ($load_scripts) {
		// Load CSS
		wp_enqueue_style( $this->plugin_slug . '-public' );

		// Load JS
		wp_enqueue_script( $this->plugin_slug . '-public' );

		$this->show_scripts = true;
	}

	return $posts;
}

Could you possibly setup a test page with the widget where the tooltips aren’t working so I can check it out?

Loading the widget with the actual widget should include the scripts, however, if you are just using the shortcode in a text widget then that doesn’t work.

I cannot as I am developing a new site that isn’t accessible externally yet. I did try adding the actual widget and it did not work either.

Thanks for the quick fixed brought my calendar back to working order. tooltips still nto working but will work on that to get them back ??

@trevsweb,

How are you including the widget? Are you using the “Google Calendar Events” widget with the plugin or are you putting the shortcode in a text widget or something similar?

Do you have a page link where I can see the broken calendar?

We just pushed 2.2.1 to fix some issues with the CSS/JS and the calendar ID encoding. Please try updating to that and then let me know if you are still having troubles after that.

Thanks!

latest version does seem to fix the issue. I noticed you wrote in the notes that you’re looking for a better detection. I think my function above does a good job of detecting the code in a widget.

Thanks for confirming, I will go ahead and mark as resolved. I may test out your function above but we already use something sort of similar by using the is_active_widget() native WP function. Thanks for the suggestions!

That won’t work for detecting shortcode inside another widget though.

That’s a good point.