• Resolved beedaan

    (@beedaan)


    I noticed there is no space between the title and the content. The theme preview displays ~10 pixels of space. My solution is to add the following to the Additional CSS

    .popmake-title {
    	margin-bottom: 20px;
    }

    Is this intentional to have no space between the content and the title?

    • This topic was modified 5 years, 11 months ago by beedaan.
Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Daniel Iser

    (@danieliser)

    @beedaan – Sorry for the delay. Not intentional, but also kinda intentional in that we try to leave the canvas blank for the most part. If we set it to 20px and you wanted 10 your in the same boat.

    That said could easily add a margin/padding option to the title in the future in the theme editor. Alternatively we are likely getting rid of the title going forward to some degree.

    To clarify we have added support for Gutenberg and removed the title field. We are adding a Title block option that will get the same styles, but since you can use any blocks in the editor at that point title is less relevant, as are “Content” theme settings beyond color.

    Hope that helps. If your issue is resolved please take a moment to rate and review the plugin or support.

    If you still need help please message us directly at https://wppopupmaker.com/support/.

    Thread Starter beedaan

    (@beedaan)

    Thanks for following up. What will happen for those of us who still use the Classic Editor?

    Plugin Author Daniel Iser

    (@danieliser)

    @beedaan – If we do end up removing it there we will probably supplement with a shortcode and continue working as is going forward. It will be there until further notice though, no official plans to remove it on the board yet.

    Thread Starter beedaan

    (@beedaan)

    Okay, thanks for the heads up. In the meantime, I’d like to clear up the issue I’m seeing with the current version. It looks like the Theme Preview has about ~10px of space between the title and the content.

    Theme Preview: https://www.dropbox.com/s/06ndpt7vmb9zdc0/popmake-preview.png?dl=0

    The actual implementation does not have that space, which I find misleading.

    Implementation: https://www.dropbox.com/s/3pbs7kjudxk8b4x/popmake-impl.png?dl=0

    Is this intentional?

    Plugin Author Daniel Iser

    (@danieliser)

    @beedaan – That is unintentional and actually caused by WP Admin styles: https://i.imgur.com/i37OcxR.png

    The title isn’t spaced, the <p> tag has a margin top as all p tags in wp-admin do.

    I will add some tweaks to make it not do that so it matches front end better.

    The theme editor is getting a lot of attention over the next few versions. v1.8 rewrote it to use the new tabbed interface like Popup Settings for better organization and easier extending. Next comes a community theme repo where you can upload / download user generated themes, ability to tweak themes on a per popup basis, and finally front end popup/popup theme editing.

    I have made changes just now for v1.8 that will remove that margin-top there so its more accurate representation. That said if your theme had similar margin-top on all p tags then it again wouldn’t match, so I’m not sure there is an ideal solution there honestly.

    Hope that helps. If your issue is resolved please take a moment to rate and review the plugin or support.

    If you still need help please message us directly at https://wppopupmaker.com/support/.

    Thread Starter beedaan

    (@beedaan)

    Thanks for the info. I’m looking forward to the update!

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Title Does Not Have margin-bottom’ is closed to new replies.