[Theme: Oenology] Header graphics issue

Would I add that function to the functions.php file as before?

For that type of change, I would strongly recommend using a Child Theme. But, whether in Oenology itself, or in a Child Theme: yes, you would put it in functions.php.

just curious .. why would you ever want to add a shaded overlay to a non default header image or is that just some leftover code from something else?

It is a design decision. ?? Mainly, I wanted to blunt the contrast of the available header images, so that the header text would display more legibly.

What I can do, though, is only apply that opacity if the header is set to display the header text. I’ll add that as a fix for the next Theme version.

I took your advice and created a child .. good thought.

Anyways I cannot get it to go with my functions.php file. I’m sure you can look at it and in 10 seconds tell me where it’s wrong. It’s the php flags I’m sure ..

<?php
function custom_oenology_header_style() {
?>
<style type=”text/css”>
#site-header-text {
background: none;
}
</style>
<?php

// Use a priority of 99, to ensure this outputs last
add_action( ‘wp_print_styles’, ‘custom_oenology_header_style’, 99 );
?>

Looks like you’re missing a closing brace on your function call:

<?php
function custom_oenology_header_style() {
    ?>
    <style type="text/css">
    #site-header-text {
        background: none;
    }
    </style>
    <?php
} // <-- YOU SEEM TO HAVE LEFT OFF THIS CLOSING BRACE
// Use a priority of 99, to ensure this outputs last
add_action( 'wp_print_styles', 'custom_oenology_header_style', 99 );
?>

Okay, well i wasn’t able to get the child functions.php approach to work. I THINK it was because of the add-action, which seems to only affect the print view of the page. I also tried some other approaches such as add_action ‘after_setup_theme’ but no luck there either.

in the end I edited the theme-setup.php file

I would vastly preferred to use the child functions.php so that it won’t break on updates but such is life. Looks great so far.

You could try changing:

add_action( 'wp_print_styles', 'custom_oenology_header_style', 99 );

…to this:

add_action( 'wp_head', 'custom_oenology_header_style', 99 );

I could help you troubleshoot on your test site. The main things to check are:
1) Is the defined <style> being output properly in the rendered HTML document?
2) Is the defined <style> being output after the default header image style tag?

I reverted the theme-setup.php and made the suggested change and it works!

Fantastic!

I had forgotten that the custom image header callbacks output at wp_head, rather than an earlier hook. ??

If you wouldn’t mind doing me a favor (it helps me keep track of open issues): if the issue is resolved to your satisfaction, can you mark the topic as resolved?

I did that but I guess I didn’t click the “change” button below it ??