Theme not ready for translations

  • I intended to use this theme for a site in german language. But unfortunately not all strings within the theme’s files ar ready for translations.

    Example file: /template-parts/post/content-none.php
    Problematic code:

    esc_attr('Nothing found for: %s','totalpress')

    should be replaced with

    esc_attr_e('Nothing found for: %s','totalpress')

    in order to be ready for translations.

    In my child theme, which is based on ‘totalpress’, I now have to make duplicates of all those files with hardcoded strings and replace them.

    And when ‘totalpress’ gets an update, I have to repeat these steps with all affected files.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Theme Author ThemeAWESOME

    (@tsquez)

    Hi there,

    I do apologize for any inconvenience. Yes, at the moment this is true. This issue was brought to my attention and was corrected. I haven’t released the update yet as I was waiting for Zurb to release Foundation for Sites 6.5…but this isn’t happening. I asked this question just last week https://github.com/zurb/foundation-sites/issues/11455

    And when ‘totalpress’ gets an update, I have to repeat these steps with all affected files.

    Actually that’s not true. You will have already made the changes in your child theme so there will be nothing for you to do as the update will take care of replacing the strings properly.

    I will release an update soon. Maybe today or maybe over the next few days.

    Again I apologize for any inconvenience.

    Thread Starter szerner

    (@szerner)

    Hi @tsquez,

    thank you for looking into this. Now I’m a little bit confused about what an update of the parent theme (your totalpress theme) means for my child themee:

    If I duplicate some parent theme files into my child theme’s directory, and the parent theme gets an update to those files, I assumed that I would have to duplicate (and modifiy for i18n) them again. Otherwise my child theme would use the outdated code of the duplicated (and modified) child theme files. Or does this happen automatically?

    Thanks again, your help is greatly appreciated.

    Theme Author ThemeAWESOME

    (@tsquez)

    Hi there,

    Well now that I look at it you would have to change what you’ve done.

    Instead of esc_attr_e it needs to be changed to __(. So if you have used esc_attr_e then change everything to __(.

    Not only that but there have been some changes made in the theme that may affect your child theme. So hopefully you are developing locally or on a demo server and not a live site. When I release the update you should be able to see a list of changes in the TotalPress Repo.

    I have also created a .po file for the theme and added a language folder.

    Look for the update to be released here shortly.

    • This reply was modified 6 years, 7 months ago by ThemeAWESOME.
Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Theme not ready for translations’ is closed to new replies.