Theme Check problem

  • Resolved misharnet

    (@misharnet)


    10 years, 1 month ago

    I am creating my first WP Theme and I would like to upload it to www.remarpro.com. That’s why I use, as recommended, Theme Check Plugin.

    I resolved other issues, except these two.
    1. REQUIRED: The <title> tags can only contain a call to wp_title(). Use the wp_title filter to modify the output

    I understand that is related to title tag in header.php, am I wrong?
    This is my header:

    <!doctype html>
<!-- paulirish.com/2008/conditional-stylesheets-vs-css-hacks-answer-neither/ -->
<!--[if lt IE 7]> <html class="no-js lt-ie9 lt-ie8 lt-ie7" <?php language_attributes(); ?>> <![endif]-->
<!--[if IE 7]>    <html class="no-js lt-ie9 lt-ie8" <?php language_attributes(); ?>> <![endif]-->
<!--[if IE 8]>    <html class="no-js lt-ie9" <?php language_attributes(); ?>> <![endif]-->
<!-- Consider adding a manifest.appcache: h5bp.com/d/Offline -->
<!--[if gt IE 8]><!--> <html class="no-js" <?php language_attributes(); ?>> <!--<![endif]-->

<head>
	<meta charset="<?php bloginfo( 'charset' ); ?>" />
	<!-- Always force latest IE rendering engine (even in intranet) & Chrome Frame -->
	<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"><title><?php wp_title( '|', true, 'right' ); ?></title>
	<meta http-equiv="cleartype" content="on">

	<!-- Responsive and mobile friendly stuff -->
	<meta name="HandheldFriendly" content="True">
	<meta name="MobileOptimized" content="320">
	<meta name="viewport" content="width=device-width, initial-scale=1">

	<link rel="profile" href="https://gmpg.org/xfn/11" />
	<link rel="pingback" href="<?php bloginfo( 'pingback_url' ); ?>" />

	<?php wp_head(); ?>
</head>

    What is wrong with it?

    2. REQUIRED: screen_icon() found in the file class-tgm-plugin-activation.php. Deprecated since version 3.8.

    Line 381: screen_icon( apply_filters( 'tgmpa_default_screen_icon', 'themes' ) );

Line 1584: screen_icon( apply_filters( 'tgmpa_default_screen_icon', 'themes' ) );

    I understand that, but I don’t know with what should I replace it?

    I am really greatfull for your potential answers.

Viewing 15 replies - 16 through 30 (of 31 total)

  • I’m glad we figured this out Samuel. An update that at the very least listed the number of files found that contain title would do wonders in clarifying that fact, there was no way for me to know just from the error that it checked all files in the directory. Wouldn’t be that hard add a counter to it, I would do it myself but I don’t want to step on your toes.

    Either way though, wonderful plugin. Glad you guys built it. That online theme checker though, themecheck.org, something really useful that it does is check for optional files and lets you know if you don’t have them. If you could implement that in your plugin that would be amazing.

    Thank you Samuel, happy coding!

    Moderator Samuel Wood (Otto)

    (@otto42)

    www.remarpro.com Admin

    The themecheck.org stuff is not related to the plugin at all.

    misharnet: it checks all files in the theme’s directory and subdirectories. It’s really quite straightforward in this respect. The purpose of the plugin is to check themes for issues that you might have when uploading the theme to our directory here. If you have random unrelated files in your theme, then it will check them too, just like as if you zipped up the entire directory when submitting it to the theme submission form.

    Thread Starter misharnet

    (@misharnet)

    I understand that. Thanks. don’t get me wrong, I am not assuming that there’s might be any problem with your plugin, I am sure that it’s up to me. It is just a little bit frustrating that I have resolved all the other issues, and it’s takimg me so long to resolve this one. I’ll handle it somehow.

    It’s a great plugin, the only issue I have with it is that the title error does not specify that it’s checking multiple files, it’s a beginners trap.

    Thread Starter misharnet

    (@misharnet)

    I found what’s wrog! There was one line with <title></title> tag in TinyMCE folder. I remove the folder and now my theme passed the check!

    Thread Starter misharnet

    (@misharnet)

    It was in the window_post.php on line 11. If you use TinyMCE check that file.

    Moderator Samuel Wood (Otto)

    (@otto42)

    www.remarpro.com Admin

    WordPress includes TinyMCE itself. You shouldn’t need to include that code in your theme.

    I’m the author of themecheck.org. I feel very bad about what you say, Samuel. What makes you think we are malicious ? This is absolutely wrong.
    We’ve already been in touch about themecheck.org and you never told me you felt inconfortable with the name themecheck.org.
    We made a lot of improvements to the code of the plugin (e.g. : comments are filtered ?? ) and made a web site with it. The code of the site is open source and available to every one on github. I also contacted you to give you patches for the plugin. What’s wrong ?

    Moderator Samuel Wood (Otto)

    (@otto42)

    www.remarpro.com Admin

    @guillaume Baudhuin I have no emails from you in my archives, so if you did send anything to me, then I no longer have it.

    However, had you asked me first, then I would have told you not to create that site or at least not to use the plugin’s name for it. That site is not an official site, and using the same name makes a clear implication that it is official in some way. Look above, people used it and thought that what it said mattered, when it did not.

    There’s nothing wrong with using the theme-check code or improving upon it. However, you need to make it much more clear that your site is not official, not part of the plugin, and not part of the www.remarpro.com system.

    (I mailed you at your ottodestruct mail and you responded on 2014/04/03)

    I didn’t ask you first because I didn’t realize it would have these consequences, and looking at your message on wp tavern in march (just after the launch of themecheck.org), probably you neither (here) :

    I wouldn’t be too hard on the service[…]I neither endorse the service nor disparage it.

    I want every one to be happy and themecheck.org’s visitors know where they are, so i will add a clear mention on themecheck.org homepage that it is not official, not part of the plugin, and not part of the www.remarpro.com system.

    Moderator Samuel Wood (Otto)

    (@otto42)

    www.remarpro.com Admin

    Fair enough. Clearly there’s some confusion there, is all. Been seeing a lot of that lately. It’s only mildly annoying. ??

    okay. i feel mildly better ??

    CyberAbel

    (@cyberabel)

    Hello misharnet, i have fixed that specific issue with my wordpress theme too, but not in the way you resolved it. Example of my theme <title> tags:

    <title><?php $theme->meta_title(); ?></title> original

    <wp_title><?php $theme->meta_title(); ?></wp_title> new

    And that helped me got my trouble fixed! And Theme Check is awesome! Cheers.

    CyberAbel

    (@cyberabel)

    Update! Now when i update those it gives the opposite issue:

    REQUIRED: The theme needs to have <title> tags, ideally in the header.php file. Any additional thoughts would be appreciated! Cheers.

    Hello everyone,

    I had the same issue with an underscores generated theme and this is how i solved it.
    In extras.php on line 80 you’ll find
    echo '<title>' . wp_title( '|', false, 'right' ) . "</title>\n";
    just replace it with

    ?>
<title><?php wp_title( '|', true, 'right' ); ?></title>
<?php

    That’s all folks ??

Viewing 15 replies - 16 through 30 (of 31 total)
  • The topic ‘Theme Check problem’ is closed to new replies.