Text domain issue

Hi @joroabv,

Thanks for the post.

Could you give us more details about this notice?

Do you have the steps for us to reproduce the notice on our test sites?

We’ll wait for your response!

Hi, I just tried this on a vanilla setup and it doesn’t happen. It is probably related to the changes WP made to the language domains loading recently, as you may imagine, but looks like it is specific to my setup (which is quite complicated) somehow. I’ll debug further when I have the time and come back to you.

So, I think the issue comes from the fact that you’re using some translation strings in the get_plugin_config method, which apparently is called early. I have no idea what is different between my full setup and the vanilla setup I tried and why the issue didn’t popup on the vanilla setup, BUT … if I just replace the __( ‘Content Control’, ‘content-control’ ) with a raw string ‘Content Control’ in the two places where it is used in get_plugin_config – the issue goes away. I hope this gives you enough clue, but if not – let me know what else do you want me to test/debug and I’lll try to help you out with this.

Ooooookay .. I also found out what is the difference between the vanilla setup and mine. It was too … vanilla :-). You actually have to change the language in Settings > General to something else than English and then the issue triggers right away along with the : “Function _load_textdomain_just_in_time was called?incorrectly. Translation loading for the?content-control?domain was triggered too early”.

Then the removal of the __() in the get_plugin_config fixes the Loco unloaded warning, also fixes the ‘_load_textdomain_just_in_time called incorrectly” warning in the backend, BUT this one still remains in the frontend – so for a complete fix more work is needed. I’ll leave this up to you :-).

So, in short, steps to reproduce : install WordPress, content-control and loco translate. Change the default WordPress language to different than English. (I also added a content-control rule to make sure the plugin get’s involved, but from what I see in the code – it is not necessary).

Hi @joroabv,

Thanks for all the details.

We’ve forwarded this issue to our dev team so they can take a look.

We’ll let you know once we receive feedback.

We appreciate your patience! ??

@joroabv – resolved in next update going out. Thanks for the extra details.