tablepress-custom.css breaks when minified

Hi,

thanks for your post, and sorry for the trouble.

Now, the missing semicolons are no problem, as the last declaration in a CSS block does not need one. It is however weird that there’s CSS missing in the minified version.
Could you please post a link to the page with your table, so that I can take a direct look at the CSS files?
And did you only ever edit the CSS through the “Custom CSS” textarea or did you maybe manually edit the unminified file on the server?

Regards,
Tobias

Thanks for the response Tobias,

Only ever edited via the Custom CSS text area.

Link is https://strongcubedfitness.com/new-index/

Keep in mind that I’ve presently removed the .min.css file so the layout is being rendered from the .css file only.

Hi,

thanks for the link.
Ok, if the minified file is removed, I can’t check unfortunately.
Now, where did you get your current minified file from?

Could you please restore everything by putting your current CSS into the “Custom CSS” textarea again and clicking “Save Changes”?

Regards,
Tobias

Hi,

thanks for the link.
Ok, if the minified file is removed, I can’t check unfortunately.
Now, where did you get your current minified file from?

The site is served via Cloudflare for caching, minification, etc.

Could you please restore everything by putting your current CSS into the “Custom CSS” textarea again and clicking “Save Changes”?

It’s always edited & managed via the Custom CSS textarea, but I’ll re-save the CSS so it generates the minified file.

Considering that most reasonably well managed sites either use a caching/minification plugin or a service like cloudflare, it probably makes sense to have the minifcation functionality managed as a separate checkbox?

Hi,

ok, thanks for that! It’s really weird that the minified file is shortened like that, and I don’t have an explanation really… Could you test again with some entirely new/unrelated/demo/example CSS? Just to see that the actual minification works?

And no, from my experience, not that many sites use caching/minification on the server directly, so a checkbox for this would not be beneficial. Most people don’t even know what minification is, so that this would just confuse them. I’m actually even thinking about removing the other checkbox about saving the CSS in a file to make things cleaner.

Regards,
Tobias

Done. It’s preserving the initial content (the .tablepress* stuff).

Possibly related to issues the caching plugin (W3TC) and Cloudflare?

Hi,

so, other CSS code than what you have now works?

I don’t think that it’s a conflict. I could maybe imagine that Cloudflare tries to minify the minified file again and that that’s where things get lost.
How does the minified file look like if you access it via FTP (i.e. where the Cloudflare minification does not kick in)?

Regards,
Tobias

That’s still a conflict (although the conflict is either in W3TC or Cloudflare).

That said, minifying a single file is pretty useless when it is being done on a system with a dedicated minifcation plugin present.

Even without it, it will cause an additional request and increase load & rendering time for the page (negative pagespeed impact). With it, it (also) causes unnecessary requests and CPU use.

At a minimum, IMHO, there should be an advanced option to disable the minify functionality.

And if you’re considering removing the custom file checkbox, you should – IMHO – just integrate the CSS into a single tablepress.css file when saving the textbox.

Hi,

yes, minifying a single file is extra work if there’s a dedicated plugin on the server, but as that’s only being done once while saving, it’s not that much of overhead. It’s a one-time operation.

And I don’t really see where disabling the minify functionality would be beneficial here. Instead of thinking about that, we should probably try to find out why the minification does not work in your case, i.e. whether the minification in TablePress is broken, or whether the other minification plugin causes this.
Could you therefore maybe turn that other plugin off temporarily, so that we can start with investigating the minification in TablePress?

And with your last paragraph, you bring up a great idea, that I will definitely consider for the next release! ??
If TablePress creates a minified file, it could also add in the default CSS there, to save another HTTP request! Thanks for bringing that up! (I’ll just need to add some checks after a plugin update (where the default CSS might have changed).

Regards,
Tobias