Survey pagination bug

During some work with a client site, we’ve discovered a bug that occurs when querying the next page for survey lists larger than the hardcoded page size (100). We figure this might be an obscure error, as not many clients would have over 100 published surveys – our client hasn’t unpublished a survey since 2011, and there are currently over 100 published surveys.

This is the error message we’re getting from the plugin logs:
2017-12-21 17:06:24.741157 - ERROR --> GFLuminate::get_luminate_surveys(): Getting luminate surveys. Error 403 - {"errorResponse":{"code":"1","message":"Unable to process request."}}

And this is the error message seen in Luminate’s API logs:

ERROR 2017-12-21 11:06:24,702 [ajp-nio-8007-exec-1] IP-XX.XX.XX.XX ConsId-0 URL-https://secureX.convio.net/CLIENT/site/CRSurveyAPI  - fromIndex(200) > toIndex(113)

java.lang.IllegalArgumentException: fromIndex(200) > toIndex(113)
	at java.util.ArrayList.subListRangeCheck(ArrayList.java:1006)

We’ve been able to successfully pull surveys in our testing environment by altering the page size to 200, and we’re currently recommending to the client that instead of using a modified version of the plugin, they should unpublish any unused surveys to get the total below 100, hopefully well below.