Support for SQL Server DB

Also, I’ve replaced the code provided here into login/db.php and formatted all characters ( ” ; , ‘ ) to text file format for adding. It crashes the site with the error:

The site is experiencing technical difficulties. Please check your site admin email inbox for instructions.

There were a few unescaped characters in the code provided in the above url is all. I’ve formatted again, if anyone would like to test (my knowledge of php and sql server is basic) but here is the formatted file.

• This reply was modified 5 years, 8 months ago by TomTom7.

Hey Tom,

You’re all over this yourself – love it! ??

Just wanted you to know that I’m not ignoring you and I’m going to look at your changes now.

Tom

Hey Tom,

I’ve had a read and understandably as a proof of concept, you’ve written over a lot of the existing options which means I can’t easily integrate this in.

If you would like to see an option to support this integration in the actual plugin code base so that you’ll get future updates etc there are two ways ahead that I would suggest.

1) I’ll add it to my backlog and try and get a test environment setup and see if I can integrate your logic in with what already exists. (Not likely to be super soon to be honest)

2) You could make a pull request from the git repo and write the full integration your self. I’ll then test it and if it all looks good my end I can integrate it in to a future release and will of course credit you as a contributor.

You may not need this integrated and are quite happy to continue using your own adapted version of the plugin.

Just wanted to see how you wanted to progress.

Thanks,

Tom

Hi Tom,

Amazing on the rapid support and feedback. The code I’ve added above was from a user on another post of yours on the same topic. It crashed the site but only due to formatting in special characters and unescaped quotes.

I just added it in the hope that someone more experienced than myself could properly verify if it was good. I’m currently learning php so I might revisit this again soon!

I suppose a concern would be how the database dropdown option might affect this for example if MySQL is chosen. MSSQL would be a great addition to the plugin. And kudos on the great work and support. It is the only plugin of it’s kind for wordpress!

Thanks,

Tom

Hey Tom,

Really glad you like it. If you wouldn’t mind taking the time to write a one line review I’d be very grateful.

Moving forward, I’ll add this to my backlog of features for now. Do you have a deadline of when this would be useful? Can’t make promises but it may sway my timeline.

Thanks,

Tom

Hi Tom,

I’ll gladly leave a review. Realistically, this feature would be great if it could be implemented in around 4 weeks. Maybe that is unrealistic for you? If it were, I would definitely purchase if this feature was even added as a premium option.

Thanks again,

Tommy

Hey Tom,

Let me see what I can do. Can’t make any promises but I will keep you up to date. I welcome you to check in and chase to see how I’m getting on over the next few weeks – I won’t think it’s rude.

If I deliver in four weeks I’ll let you buy me a beer to say thank you ??

Tom

Hi Tom,

Thanks for the continuous support. I will check in from time to time so. I’ll even go as far as buying you 2 beers. ?? It would be a great addition to the plugin.

Thanks again,

Tommy

Hey Tom,

I hope all is good with you. I am just checking as you requested to see if you’ve had the time to begin the MSSQL integration in the plugin?

Thanks,

Tommy

Hey Tom and Tom. I needed the same support so I created a fork and pull request based on the file Tom referenced earlier (with a few tweaks to make it work with the latest code). I’ve tested it on my end with SQL Server 2017 and everything seems to be working. This is my first time using this plugin so I am not 100% sure. I am turning it over to my QC department to be sure.

If you want to test as well, my fork and branch are located here:

https://github.com/jjepson/wordpress_external_login_plugin/tree/add_mssql_support

Good luck!

Jason

Hey @jjepson,

Thanks for taking the time to do this.

Apologies to both you and @tomtom7 – life is busy at the moment so struggling to get round to integrate this.

Will try and have a look at this this morning but please don’t hesitate to keep chasing.

Thanks,

Tom

Hey @jjepson,

I’ve made some modifications to your pull request and moved it into master.

Please could you test master and confirm that this is all working before I deploy an updated version of the plugin.

Once this is done, it’d be great to get feedback from you @tomtom7 to confirm that the plugin update is working for you.

Thanks,

Tom

Hey @tomtom7,

I’m ready to make this live when one of you confirms this is working. I thought I’d share a link to the code incase you wanted to validate it for me before I make it live.

@fbosito and @bartekryt may also be interested in this?

I think a lot of this was your original work @fbosito so thank you!

If you give me the thumbs up on this version I’ll deploy an update live.
https://github.com/tbenyon/wordpress_external_login_plugin/archive/master.zip

Thanks,

Tom

Looks good to me! Yes thank you @fbosito! I didn’t know where the original came from or I would have thanked you in the first place!

Best,

Jason