• Resolved wunch

    (@wunch)


    Just a minor suggestion:

    As far as I can tell, the only place the ConstantContact_Settings::privacy_notice_markup() is used is when you click on the checkbox on the Settings page for Google Analytics. If the user never clicks that box, the ‘ctct_privacy_policy_status’ option is never set, and that notice gets generated on every admin page since it’s hooked in to the ‘admin_footer’ hook (though it’s hidden with CSS). The reason I noticed this is because I had a misconfiguration that resulted in your CSS not being loaded, so I could actually see it on every admin page.

    A simple fix might be something like this in class-settings.php:

    public function privacy_notice_markup() {
        if ( !$this->on_settings_page() || $this->privacy_policy_status() ) {
            return;
        }
    ...
    }

    I’m using plugin version 1.2.5.

Viewing 2 replies - 1 through 2 (of 2 total)
Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Suggestion: restrict privacy_notice_markup to Settings page’ is closed to new replies.