Suggestion for improving the plugin

Hi @retrobeatcom,
thank you for your suggestion. Give me a few hours to check your code and then we can continue the discussion.

@retrobeatcom,
your code based on Version 2, but as we moving forward to version 3 I will add code that is related to the new version. (The process is similar)

To summarize your suggestion:
You would like to introduce a new field called user_fallback. In your case it contains ‘member’. When WordPress validate_username rejects the username based on the first and last name, you would like to use $user_prefix . $user_fallback as the username. Right?

By default we use the following fallback: $user_prefix . $userIDatFacebook then we check the existence of this username and we adding incremented number to it while we found a free user name:

while (username_exists($sanitized_user_login)) {
    $sanitized_user_login = $default_user_name . $i;
    $i++;
}

In your example the problem comes when you have 500 user who have Cyrillic character in their name. Then for the 501th user WordPress needs to check in the databse 500 possible good usernames which are not free:

1. fb-member-1 – taken
2. fb-member-2 – taken
3. fb-member-3 – taken
4. fb-member-… – taken
5. fb-member-499 – taken
6. fb-member-500 – taken
7. fb-member-501 – free

Possible future solution in our plugin
What we could force users to enter username when we are not able to generate one based on the first and last name.

What you could do
If you are running a site where most people user cyrillic alphabet, you could enable the usage of cyrillic characters in usernames:

function acu_sanitize_user($username, $raw_username, $strict) {
    $username = wp_strip_all_tags( $raw_username );
    $username = remove_accents( $username );
    // Kill octets
    $username = preg_replace( '|%([a-fA-F0-9][a-fA-F0-9])|', '', $username );
    $username = preg_replace( '/&.+?;/', '', $username ); // Kill entities

    // If strict, reduce to ASCII and Cyrillic characters for max portability.
    if ( $strict )
        $username = preg_replace( '|[^a-zD°-??а-я0-9 _.\-@]|iu', '', $username );

    $username = trim( $username );
    // Consolidate contiguous whitespace
    $username = preg_replace( '|\s+|', ' ', $username );
    return $username;
}
add_filter('sanitize_user', 'acu_sanitize_user', 10, 3);

Please let me know what your thoughts!

Hello,
thanks for the quick reply!

On your first question, yes that’s what I propose. The possibility of setting custom default username in the admin area. And also, always to include the prefix. In my case, I depend on that prefix to execute some custom actions for these users. But anyway, it will be much more consistent if all users have it, right?

The problem really occurs when there are too many users with the default name in the DB. $username . $index in this case $index can always be replaced with the provider ID or simply with build in rand(). It will do the trick in both cases.

If a feature is introduced, in my opinion, it should prepend the prefix before inserting the username to the db.

Thanks for the suggestion about the Cyrillic usernames, but I prefer to keep all usernames in Latin. It simplifies searching and adding custom scripts that manage these users.

PS. I Just checked the code located in \includes\providers.php

        $username = strtolower($first_name . $last_name);
        if (empty($username)) {
            $username = strtolower($name);
        }
        if (empty($username)) {
            $username = str_replace(array(
                '@',
                '.'
            ), '', strtolower($email));
        }

The part where you parse the username from the email is not a good idea. The email is something private and using it to build a login name will make it publicly available to all others, that can see your username.

@retrobeatcom

Here is a possible solution based on our discussion: https://i.imgur.com/U6jGaa1.png
(If you have better name or description for this field, please share with us.)

Site owner can enter a prefix which always used and can enter a fallback which will be concatenated to $prefix.$fallback

• Username prefix on register -> value: fb
• Username fallback on register -> value: member

And we make fbmember in PHP when needed

Another approach field label idea
Site owner can enter different prefixes. Maybe it would be easier to understand and gives more freedom.

• Username prefix on register -> value: fb
• Fallback username prefix on register -> value: fbmember

Which one do you prefer?

Also I do agree with you with the email suggestion, I will remove that in the next version.

The provider prefix is always added to the user on registration expect in the 'nsl_' . $this->getId() . '_register_user_data' filter which can modify the username. Currently it used in the Pro Addon: when the always ask username enabled, we set the entered username here. I do not think that it would be good to add prefix to the user’s choosen username as that makes it harder to remember. But I think in your case it does not matter as you do not plan to use it.

Proposed code:

$username = strtolower($first_name . $last_name);
if (empty($username)) {
    $username = strtolower($name);
}

$prefix = $this->settings->get('user_prefix');

$sanitized_user_login = sanitize_user($prefix . $username);
if (empty($username) || !validate_username($sanitized_user_login)) {
    $sanitized_user_login = sanitize_user($prefix . $this->settings->get('user_fallback') . $providerID);
}
$default_user_name = $sanitized_user_login;

$i = 1;
while (username_exists($sanitized_user_login)) {
    $sanitized_user_login = $default_user_name . $i;
    $i++;
}

$userData = array(
    'email'    => $email,
    'username' => $sanitized_user_login
);

$userData = apply_filters('nsl_' . $this->getId() . '_register_user_data', $userData);

• This reply was modified 6 years, 9 months ago by Nextendweb.

This feature and improvements will be released in the next version.