Subscribe2 and GD

@cparodi7,

“It didn’t work” is pretty unhelpful as a description of your problem. What exactly were you expecting to happen in what plugin and what did you actually see?

The code you’ve pasted above is an example and it needs customising for your site. Where you have the line that starts with $types[] you need to specify the slug name of the custom post type you have registered (or that GD Taxonomies has registered). This is then passed to Subscribe2 and will be visible provided that the custom post type you’ve specified is properly registered in WordPress.

These articles about the API for custom posts and taxonomies may help you.

Hi MattyRob,

I was expecting the CPTs registered via GD Taxonomies to show up in:
/wp-admin/users.php?page=s2_users (and the settings page: /wp-admin/options-general.php?page=s2_settings). Essentially, get recognized/parsed by Subscribe2.

Regarding the code pasted, I did specify the slug names (tried just one CPT I have registered, then all three; neither case worked).

function my_post_types($types) {
	$types[] = 'MYPOSTTYPE';
	return $types;
}
add_filter('s2_post_types', 'my_post_types');

To help address the issue, GD Taxonomy’s author (MillaN) added a new function in his latest release: gdtt_registered_post_types() now returns an array with names of post types registered by the plugin.

He provided me with the following, which unfortunately didn’t get recognized by Subscribe2 either.

function my_post_types($types) {
 $pages = gdtt_registered_post_types();
 foreach((array)$pages as $name) {
 $types[] = $name;
 }
 return $types;
 }
 add_filter('s2_post_types', 'my_post_types');

His last reply:
“If he suggests that something needs to be done with my plugin, let me know if I can do something about it.”

If you have any suggestions, I’d really appreciate it.

Thanks,
Carlos

@carlos,

I’ve got a copy of the Gd plugin now. I’ll have a play and come back to you if I work anything out.

@carlos,

I have this working for Custom Posts now. The code does work and I think the issue is the Subscribe2 filter produces no output for you – it works silently in the background.

To check that your code is working correctly in the filter you can try this:

$s2_post_types = apply_filters('s2_post_types', $s2_post_types);
print_r($s2_post_types);

The other thing to mention is the code the author of GD gave you, I think you need to amend it slightly to access the class as follows:

function my_post_types($types) {
	global $gdtt;
	$pages = $gdtt->gdtt_registered_post_types();
	foreach((array)$pages as $name) {
 		$types[] = $name;
 	}
	return $types;
}

add_filter('s2_post_types', 'my_post_types');

Custom Taxonomies are different – they do show up along with the Categories.

MattyRob, thanks a ton for helping out with this.

I added the following to my functions.php (in this exact order):

function my_post_types($types) {
	global $gdtt;
	$pages = $gdtt->gdtt_registered_post_types();
	foreach((array)$pages as $name) {
 		$types[] = $name;
 	}
	return $types;
}

add_filter('s2_post_types', 'my_post_types');

$s2_post_types = apply_filters('s2_post_types', $s2_post_types);
print_r($s2_post_types);

It returned the following error:
Fatal error: Call to undefined method GDTaxonomiesTools::gdtt_registered_post_types() in /home/cparodi3/public_html/dev/wp-content/themes/fic/functions.php on line 145

If I remove the check code below, it loads but the CPTs still aren’t being recognized by Subscribe2.

$s2_post_types = apply_filters('s2_post_types', $s2_post_types);
print_r($s2_post_types);

Should that check code be place elsewhere?

Thanks again for helping,
Carlos

@carlos,

I got that same error but presumed that you would be using a newer version of the GD plugin that contained the new function. Once that function is available in your code that bit should work.

As for the check code I gave you – that needs to be in with some code that actually produces output – so not the functions.php file in your theme.

Try adding it to the write_menu() function in the subscribe2.php file and see if you get output on the screen when you go to Posts->Mail Subscribers.

Matty, thanks for the update, here’s the latest…

In my last test (just retried it as well), I already had the latest version of the plugin with the new function. Odd that it gave me that error. Here’s the actual function from the plugin:

function gdtt_registered_post_types() {
    global $gdtt;
    return $gdtt->active["cpt"];
}

If you’d like the entire php file, let me know.

I tried the check code in the write_menu() function – it didn’t show any output; adding “echo “test”;” did show, so it’s parsing that section.

Thanks,
Carlos

@carlos,

The code above does not work for me, $gdtt->active[“cpt”] returns NULL.

Anyway, here’s how I got everything working on my test site:

1/ WordPress with Subscribe2 6.5 and GD Lite 1.4.2 installed.

2/ Used the GD plugin to create a new Custom Post Type called ‘advert’ with all the default settings from the GD plugin. Confirmed that the new post type was available in the WordPress admin area.

3/ Added the following code to the end of the functions.php file of the active theme:

function my_post_types($types) {
	$types[] = 'advert';
	return $types;
}

add_filter('s2_post_types', 'my_post_types');

4/ Added a new ‘advert’ post and I got notification emails.

As an aside, I’ll be committing some code to the SVN late for the new version of Subscribe2. This new commit will place some text into the Settings screen to list the currently added custom post type so you can see if your filter code is working without making a new post.

I am author of Lite and Pro version of GD Custom Posts and Taxonomies Tools, and I will be adding this as a enhanced feature (one of many) to Pro version in the next few days.

Milan

Guys, thanks so much for the help — that solution sounds great, thanks!

Hi MattyRob,

Using Milan’s latest version of GD, the array test produced the following:
Array ( [0] => mlb [1] => nfl [2] => test )
..at the top of /wp-admin/edit.php?page=s2_posts.

However, at the very bottom of that page, I get this warning:
Warning: array_intersect() [function.array-intersect]: Argument #1 is not an array in /home/cparodi3/public_html/dev/wp-content/plugins/gd-taxonomies-tools/code/public/general.php on line 166

Line 166 is bolded below:

function gdtt_get_taxonomies_for_post_types($post_types = array(), $return = "name") {
    global $wp_taxonomies;
    $taxonomies = array();
    if (is_string($post_types)) $post_types = (array)$post_types;
    foreach ((array)$wp_taxonomies as $taxonomy) {
        <strong>if (array_intersect($post_types, (array)$taxonomy->object_type)) {</strong>
            if ($return == "name") $taxonomies[] = $taxonomy->name;
            if ($return == "object") $taxonomies[] = $taxonomy;
        }
    }
    return $taxonomies;
}

The CPTs still don’t show up in /wp-admin/users.php?page=s2_users.

Does that array output mean we’re on the right track?

@carlos,

It seems like we are getting closer, the test array output looks good. Not sure about that error and any impact it may have, perhaps that’s a question for Milan.

This second error is not affecting the S2 support, it is related to something else. It will be fixed in next minor Pro revision in the morning. As for S2 post types support, array is now formated properly, but maybe there is something else interfering.

@carlos,

If the output you copied above was as a result of:

$s2_post_types = apply_filters('s2_post_types', $s2_post_types);
print_r($s2_post_types);

Then from the Subscribe2 side of things you should be all set.

Hi MattyRob,

To update, with latest GD version, it now appears to be correctly sending on publication of CPTs – however, CPTs don’t show up in “/wp-admin/users.php?page=s2_users” or “/wp-admin/options-general.php?page=s2_settings”, thus users aren’t able to opt in/out. Is there anyway to update the category array/form on those pages?

Thanks again for your help,
Carlos