Submitting a patch?

  • I would like to contribute a patch to update a dependency in subversion, but I’m not familiar with how to do this with W3TC and subversion.

    The page I need help with: [log in to see the link]

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor gidomanders

    (@gidomanders)

    We have a private GIT repository and push updates to WordPress once in a while, so we don’t use the WordPress SVN like that.

    You can tell me what you think needs to be changed and I’ll discuss it with the team.

    Thread Starter robjam

    (@robjam)

    hey gidomanders,

    I was checking the plugin on the docker image

    wordpress:4.9.5-php7.2-apache

    to test W3TC and found that the current version of a dependency in MicrosoftAzureStorage (HttpGuzzle) was throwing an error

    count(): Parameter must be an array or an object that implements Countable.

    This issue was fixed in HttpGuzzle, but the Azure Storage library has not been updated to pull in this new version.

    Azure Storage has seen some API changes as well (I noticed setBlobContentType has been changed to setContentType) and this may require more effort than can be spent. An alternative would be to only update Azure Storage’s HttpGuzzle to 6.3. I have been able to test this locally and it seems to work with no errors.

    • This reply was modified 6 years, 9 months ago by robjam.
    • This reply was modified 6 years, 9 months ago by robjam.
    Plugin Contributor gidomanders

    (@gidomanders)

    Thanks for the very good explanation of the patch! I’ll discuss it with the team and check if our tests run successful too.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Submitting a patch?’ is closed to new replies.