Styling?

  • Resolved TStone

    (@tstone)


    5 years, 4 months ago

    Hello!
    I notice that all the elements are styled through hardcoded style attributes, which makes it difficult to override the styles to make it fit the overall design.

    This is in no way urgent, but it would be nice if the styles could be overridden by a child theme’s style sheet. ??

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Chris Bibby

    (@cmbibby)

    I’ve moved the styles in 1.1.1

    Thread Starter TStone

    (@tstone)

    Great! Two small suggestions.

    On your first div in the output:
    <div class="woocommerce wctc-coupon-outer" style="color:#680709;">
    it might be an idea to add an ID there, that you don’t use yourself in your own css. Maybe:
    <div id="wctc-coupon" class="woocommerce wctc-coupon-outer" style="color:#680709;">

    That way, it doesn’t matter which order your css and the user’s css load (which occasionally, in some themes, can be unpredictable). Once the user writes #wctc-coupon it has higher specificity and will not be overridden.

    —

    You’re now outputting the plugin’s css to a file, which is great! However, that file is included on every page on the site, which seems a bit excessive. ??
    Could you check to see if the page is “order-recieved” before inserting your css? Maybe something like:

    if( is_wc_endpoint_url( 'order-received' ) ){
//Insert css
}
    Plugin Author Chris Bibby

    (@cmbibby)

    Cheers, I will make sure to update it over the next couple of days.

    Plugin Author Chris Bibby

    (@cmbibby)

    All done

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Styling?’ is closed to new replies.