Struggling with embedded SVGs

Well, I guess what I should see about doing is converting all embedded images to png or jpg before rendering the PDF (though the error above indicates that what was expected to be a tag was indeed not, so the issue here might be with the input.

Are you using a particular plugin to manage your media? I’m wondering what might be producing unexpected HTML for TCPDF.

I’ll open a bug for this and will test with some embedded SVG files.

As for placeholders, that’s an enhancement request. I guess we could do that with a shortcode preceding the element to be swapped, and then defining in the admin UI a default replacement image or text string, which could be overridden in the shortcode. Does this sound like what you propose?

Cheers

Lewis

Thanks for the thoughtful response.

I am not using any plugin to manage my SVGs: just a hyperlink with the src attribute, just as you’d use for a PNG or JPEG.

I am not really asking for a placeholder to be inserted. It’s just the way that other PDF generators I’ve used have done it. But I’d prefer to use this plugin if possible because you have provided numerous additional features, especially regarding the formatting of the PDF.

I’d actually prefer that no placeholder be there at all to replace the SVGs. I am not even particularly concerned to have the SVGs converted to PNG or JPEG (although I realize that others might take a different view) because I suspect rasterization will make them look pretty bad, and I provide other means on my site for someone to download those graphics anyway.

Thanks again for looking into this!

Correction: my hyperlinks are to a folder that is managed by the s2member plugin, so I suppose that could be the cause of the particular error message. As I say, this doesn’t trip up other PDF-generating plugins. They just produce a small, placeholder image and continue to render the rest of the PDF.

If yours could render the PDF without the placeholder, that would be fantastic!

Ah… Yes, if we can’t reach the source image, we probably do give up in a puff of smoke. ??

Yes, we should handle such situations more gracefully; I agree.

It would also be prudent to make the placeholder an optional insertion (if I do add that functionality), so that site owners may decide for themselves whether to replace the image or just skip it entirely, as you would prefer.

Okay. Let me get this added to my list. Look for this in an upcoming development release.

Thanks for the substantive feedback and discussion!

Lewis

BTW, this may be a relative path issue. You might have a look at this thread, and give the plugin referenced there a spin, just to confirm. In Alex’s case, his images were missing entirely; we didn’t stumble over them. Your issue may be completely unrelated, but your mention of s2member seemed to jog my recollection.

Cheers

Thanks very much, Lewis!

I took a look at that thread and tried using a relative link instead of an absolute link. If I do that for the src attribute, the whole page becomes unusable, with much the same error being produced as I first reported (except that there’s no reference to TCPDF).

If I do it for the href attribute, a PDF is rendered — but only up to the point where the SVG is placed. Neither the SVG itself nor any subsequent text appear in the PDF.

I presume the behavior I experience is a bit different from that Alex had because we are using different plugins, albeit with very similar names.

Thanks again!

Thanks for testing and reporting back so quickly!

At least we know to look elsewhere in this case. Fair enough; I’ll see what I can do with this. I’m just not sure how quickly I can really dig into it, but I’ll try to keep it near the top of the list for my bug squashing. ??

Thanks again!

Lewis

Thanks very much, Lewis. I am just really looking forward to this issue being overcome so that I can use the plugin on my site. I have even already taken care of the CSS to style the button for the link just the way I want it!

Just so we’re clear on this, do you see any issues with JPEGs embedded the same way that you have SVGs? I’m really trying to narrow down whether this is a read issue or a rendering issue.

Thanks!

Lewis

Hmm, interesting! I don’t use any rasterized graphics on this particular site. But I have just tried out a PNG and a JPG, and they were both rendered perfectly in the generated PDF (albeit that both were placed at the end of the page, rather than where they were actually situated).

I hope that helps!

The image positioning is a whole other matter (long-standing bug which I continue to revisit). Text wrapping around images is also tricky.

It looks like we’re back to the SVG vs JPEG/PNG thing. For some reason, we don’t like your SVGs. Could you post a link or email me directly (lgrosenthal 2rosenthals com)?

Thanks. I’m glad I thought to have you test the other formats!

Cheers

Lewis

Thanks very much for continuing to look into this, Lewis!

Since I am not using PNGs or JPGs on this site, I am not particularly concerned by the positioning of them on the rendered PDF. I just reported it in case it was important to enable you to find the problem.

At the moment, I have just been testing this on my localhost development site. I do have a live site up, though, so will install it and then send you an email.

I have just sent you an email, Lewis!

Sorry; haven’t seen your email yet. ??

Perhaps it’s in your junk email folder? Re-sent anyway, just in case.