Stops ACF and Elementor looping through field + Errors

@stoffb – I think I have this patched, look for it in v2.0.7. Will push it shortly

Hi,

I have updated the plugin but although it’s not showing the errors anymore, it’s still causing problems with Elementor/ACF

Sorry, it’s actually still showing a couple of errors

Warning: Undefined array key “backup-2” in /home/tranwsdorg/public_html/test/wp-content/plugins/content-control/classes/Controllers/Admin/Upgrades.php on line 153

Warning: Undefined array key “backup-2” in /home/tranwsdorg/public_html/test/wp-content/plugins/content-control/classes/Controllers/Admin/Upgrades.php on line 153

Hi,
Like stoffb, still bugs with ACF with the last version 2.0.7

@stoffb – Grr, sorry to see that still. Can you possibly test this fix I just made. I see why it throws errors pretty clearly now, would like confirmation while I fix a couple other open issues.

The fixed line in question( ignore the comments ): https://github.com/code-atlantic/content-control/commit/dcb8857ed2de9dc2ec667bbaaa55e42ae37938b2#diff-9bef2d0f0d25cb707e140e26d774ef83f181e5b0d349f24845ad6c314f9ad86eR157-R158

• This reply was modified 1 year, 2 months ago by Daniel Iser. Reason: Fix link

Hi Daniel,
I think the bug with ACF was introduced with version 2.0.
With 2.0.5 version, still have bug (don’t have 2.0 version to test it)
I downgrade Content Control to version 1.1 and everything come back to normal.
The bug is very curious : I have CPT with ACF fields and subfields : loop on CPT is OK, then loop ACF fields inside each CPT, I miss ACF fields with the two first CPT items, following CPT have ACF fields listed well…
On my CPT pages, no ACF fields are displayed…

Debug message when reloading page after upgrade Content Control :
Fatal error: Uncaught Error: Class ‘JP\CC\Options’ not found in /***/wp-content/plugins/content-control/content-control.php:162 Stack trace: #0 /***/wp-content/plugins/content-control/content-control.php(126): JP_Content_Control->init()
But content-control.php have only 147 lines and no error displayed if I reload page again… just my ACF fields disappear for my 2 first CPT items…

Can’t figure why…
I have ACF Pro, Version 6.2.1.1.

@nomades JP\CC\Options’ is from v1. That code either means your plugin files are corrupt (half v1, half v2), or something is using our functions in your theme or custom code

I’m gonna set up acf along with elementor that I tested earlier tomorrow.

Some screenshots of what your describing would be helpful as well, specifically how ACF stuff appears, but normal content doesn’t. It leads me to think ACF isn’t using the global $post or $query when rendering things, not sure why they’d do that though.

Good morning Daniel,

Thanks for your help, the error messages have now disappeared.

Unfortunately there still is some kind of conflict between your plugin, Elementor Pro and ACF.

This is the test site with the plugin ON: https://www.wsd.org.uk/test/the-journal/features/

This is the Live site with the plugin OFF: https://www.wsd.org.uk/the-journal/features/

As you can see, when I activate your plugin, it stops the page feeding the fields from ACF in the elementor loop

Hope you can find a fix soon

Many thanks

Hi Daniel,

Here are my screenshots
With content control 2.0.8 (just downloaded from www.remarpro.com, no corrupted files possible). No ACF content generated for my 2 first CPT items… but OK from the third item !…

And the same page with Content Control 1.1.
ACF content is displayed the good way.

My functions.php worked fine from the beginning of the website 2 years ago.. Bug just appeared last days after upgrading content control from 1.1 to 2 version. I’m using Divi.
Tested on localhost and online production website : same bug

Thanks for help

• This reply was modified 1 year, 2 months ago by nomades.
• This reply was modified 1 year, 2 months ago by nomades.

@stoffb, @nomades – Could either of you provide access to those test sites with v2 active and the ability to use the plugin editor? I mainly want to comment out sections of our code to see what action/filter is interfering here.

If so you can submit a login token or credentials securely via https://contentcontrolplugin.com/support/

@stoffb,?@nomades – I just worked on a similar bug described here, and with the info I got from his setup was able to fix it in a way that should be pretty reliable.

If your issue is related to that one, which I suspect it is, then the next release (v2.0.9) should hopefully resolve it for you.

I’m happy to have you test the fixes yourself if you get a chance to confirm its resolved for you too before I release, so if your inclined to make the code changes here they are.

I was able to properly render all loops with ACF fields during my tests just now.

Hi Daniel,
v2.0.9 corrects ACF bug.
Thanks !

@nomades – Wooohoooo!!!.

Thanks for your patience, please take a moment to?rate & review?the plugin and or support to spread the word.

Morning Daniel,

Thanks for all your help.

The ACF issue is now sorted, thanks.

• This reply was modified 1 year, 2 months ago by stoffb.

@stoffb – Fantastic, thanks for the confirmation.