• Resolved Hozefa Saleh

    (@hozefasmile)


    I have noticed by reviewing blocks that stack block and grid block are not working properly. But later on, when I checked the blocks in the Custom Blocks List, I found that both of these blocks “Grid item” and “Stack item” has setting for Template Lock to “All”, I changed it to “None” and it started working.

    So I think it will be confusing for a new user that, why a grid item or stack item not working when he tries to insert anything inside it. So by default, you should keep these two default blocks setting as Template Lock “None”.

    Also, one more point is that media query sizes for desktop, tablet, and mobile are handled by your code, it should be on your settings page So that the user can set by himself the media query sizes.

Viewing 15 replies - 1 through 15 (of 17 total)
  • Plugin Author Phi Phan

    (@mr2p)

    Thank you for your feedback. I’ll update those default settings for core blocks in the next version.
    I’ll add the functionality for editing media query breakpoints as well.

    Please give it a rating when you can, I would greatly appreciate it.

    Thanks, Phi.

    Thread Starter Hozefa Saleh

    (@hozefasmile)

    Hi the issue is still not resolved. I found that only when I take a pattern from your pattern collection, only then your default grid block works. When I try to add it directly from the block inserter option, its grid-item is lock. And I am not able to add anything inside it. Even on Template Lock “none”, its not working. Please check it.

    Plugin Author Phi Phan

    (@mr2p)

    Thank you @hozefasmile.
    Could you please explain more about your test cases? I never had this kind of issue on my sites.

    Phi.

    • This reply was modified 2 years, 5 months ago by Phi Phan.
    Plugin Author Phi Phan

    (@mr2p)

    Ah, I did not automatically override the settings for the default built-in blocks on old sites. But new install sites will get the latest settings for the default built-in blocks. In the future, I may add some kind of ‘sync’ functionality to update the settings for the built-in blocks.

    Thread Starter Hozefa Saleh

    (@hozefasmile)

    New install sites means new wordpress setup or new install of you plugin? Anyway I will wait for your next version of plugin.

    Plugin Author Phi Phan

    (@mr2p)

    I mean a new install of this plugin, for the sites that had already installed an older version of this plugin, users can manually edit the settings for built-in blocks in the admin.

    Thread Starter Hozefa Saleh

    (@hozefasmile)

    No, its not working in that way too. For more clear explanation I have created a short video for you. https://postimg.cc/RqTqTHqc
    You see in video that grid item block not allowing to add any block inside it. Then I go to Custom Blocks => All Blocks => Edit Grid item => Changed Template Lock to None
    Then Again trying to add grid block on a page and its still lock, not able to anything inside it.
    But when I use “Add pattern” button and choose a grid pattern from it. It works, we can remove or add anything inside the grid item block in those insert block pattern.

    Plugin Author Phi Phan

    (@mr2p)

    Thank you @hozefasmile for the video, I think that issue has nothing to do with templateLocking. I got that error in the Gutenberg plugin version 14.3.0 for all container blocks includes core/group block. It got fixed in Gutenberg version 14.3.1. What’s your version of WP? Do you install Gutenberg plugin? What’s its version?

    Thread Starter Hozefa Saleh

    (@hozefasmile)

    Yes I am using wordpress latest version 6.0.3 and also I have installed Gutenberg plugin with its latest version 14.3.1 , but in that version also have to same issue, if you want to check I can’t provide you a login detail of a sample site in private to investigate.

    • This reply was modified 2 years, 5 months ago by Hozefa Saleh.
    Plugin Author Phi Phan

    (@mr2p)

    Here is the issue Cannot add blocks to a nested group or row block when editing templates
    Can you upgrade to 14.3.1 and test it again?

    Thread Starter Hozefa Saleh

    (@hozefasmile)

    hummm, but I checked that when I disable the Gutenberg plugin, it start working. So there some conflicting issue between Gutenberg plugin and yours plugin. As I said I am already using latest version of Gutenberg 14.3.1

    • This reply was modified 2 years, 5 months ago by Hozefa Saleh.
    Plugin Author Phi Phan

    (@mr2p)

    I’ll look into it further. The Gutenberg plugin adds pointer-event: none to the nested empty container blocks in version 14.3.0. I’ll test it again, but that issue is unrelated to templateLocking feature.

    Phi.

    Plugin Author Phi Phan

    (@mr2p)

    Just do a quick test on WP version 6.0.3 with the Gutenberg version 14.3.1 without the Content Blocks Builder plugin.
    It doesn’t work with core/group block. You can test it by adding a core/group and then adding a nested core/group.
    Maybe they will fix it soon. Anyway, it works well in the WP 6.1 beta version.

    Thread Starter Hozefa Saleh

    (@hozefasmile)

    hummm, you are absolutely right. Its not got resolved in even Gutenberg version 14.3.1 , I have added a comment in the the issue at github https://github.com/WordPress/gutenberg/issues/44989 , let see when the got it resolved. And if this issue is already resolved in WordPress 6.1 beta version then we just have to wait for 8 days, it’s releasing on 1 Nov ??

    Plugin Author Phi Phan

    (@mr2p)

    I guess the version that includes in WP 6.1 is lower than 14.3.0, so if you install the Gutenberg plugin then you will still get the error until they fix it.

Viewing 15 replies - 1 through 15 (of 17 total)
  • The topic ‘stack and grid block issue’ is closed to new replies.