SSL compat should imply https regardless of protocol of tracked site

  • Resolved b-smark

    (@b-smark)


    7 years, 4 months ago

    Hi

    I changed

    echo ‘((“https:” == document.location.protocol) ? “https” : “http”) + “://’ . $options[‘address’] . ‘/”; ‘;

    to

    echo ‘”https://’ . $options[‘address’] . ‘/”; ‘;

    because if the Piwik server supports SSL it should be reached over HTTPS always, otherwise the 1st trial call via HTTP would send url-params in clear over the wire even if the server switches to HTTPS.
    Indeed the check would be useful on ssl_compat = false side, as the piwik HTTP call from a page over HTTPS usually raise the mixed-content blocking by the browser.

    So in short I think you should just drop the check and make the call straight over HTTPS if supported.

    thx

Viewing 3 replies - 1 through 3 (of 3 total)

  • Hi, @b-smark,

    You’re right. I can’t remember why that particular piece of code is there, but i think it has to do with how the tracking code was generated by Piwik 1.x .

    I will fix that ASAP, probably before the end of this week. I’ll update this ticket then.

    Thanks for taking the time to report that!

    Kind regards,
    @sergiorcs

    Hello again, @b-smark,

    As promised, i have just released an update to this plugin, to address the issue you reported.

    Thank you for your help. If you find any other issue or have any suggestions for possible improvements, just let me know.

    Kind regards,
    @sergiorcs

    Thread Starter b-smark

    (@b-smark)

    Hi

    good, seen & updated ??

    thank you @sergiorcs

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘SSL compat should imply https regardless of protocol of tracked site’ is closed to new replies.

Tags