• Resolved Konstatninos

    (@skredlemon)


    Hi Popup Maker team,

    I trust it was not in your intention to introduce spam popups after the last update, so I am bringing this issue to your attention.

    After updating to the latest version of the plugin, I was seeing an auto-opening announcement popup on every page load, regardless of whether I was logged in as an admin or not. Jumping in the popup maker administration page I can see the introduction of an “Example: Auto-opening announcement popup” which appears like it was the culprit for this behavior. After I disabled that it went back to normal.

    Please review and advise if this is default behavior. If if is, I reckon you should fix it for future updates, so that it doesn’t happen again. We have been using your popup for over two years in dozens of sites. We are familiar with what it can do that. Even if there is a new feature, there are better, more user friendly, and especially more visitor friendly ways to make us aware of them. No visitor is interested in what new options a plugin offers. Only admins should see this.

    Please review and advise.

    Thanks.

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Support Kim L

    (@kimmyx)

    Hi @skredlemon,

    Thank you for the heads up and sorry to hear about your experience with the auto-opening popup.

    This is certainly unusual behavior as “Example: Auto-opening announcement popup” is disabled by default after installing and activating the plugin.

    Nevertheless, we’ll make sure to double-check to see if we missed something.

    Thanks again for using Popup Maker!

    Thread Starter Konstatninos

    (@skredlemon)

    Thanks for the prompt reply. I too believe it was by mistake, hence why I reported this in the first place. I hope you get it addressed for future updates and it doesn’t show again with the next version of the plugin.

    Cheers!

    Plugin Author Daniel Iser

    (@danieliser)

    @skredlemon – Seems something is off in your install. I checked the code just now (links below) and have recently done fresh installs this weekend testing out some bug fixes we have coming.

    The example popup comes defaulted to disabled. Only if the toggle was flipped to enabled could it begin to show. In fact it’s code wouldn’t even get loaded on the page as published & enabled are both checks before that happens.

    That said we haven’t pushed an update for the core plugin in over 2 months, so I’m not sure what update your referring to or if it in fact has any impact on what you saw.

    – Default popup settings, marked disabled: https://github.com/PopupMaker/Popup-Maker/blob/master/includes/pum-install-functions.php#L32

    – Check during load if popup is loadable: https://github.com/PopupMaker/Popup-Maker/blob/master/classes/Site/Popups.php#L108

    – Popups actual is loadable check: https://github.com/PopupMaker/Popup-Maker/blob/master/classes/Model/Popup.php#L852-L865

    That said in the future we might look into only installing the default popup if its a new install.

    Hope that helps.

    • This reply was modified 2 years, 2 months ago by Daniel Iser.
    Thread Starter Konstatninos

    (@skredlemon)

    Hi @danieliser thanks for the insight.

    We have had some hosting performance issues lately, but can’t see how they could have caused something like that to be honest. Perhaps something to do with the wp-cron? Is your plugin dependent to that? Either way, I’m skeptical of it.

    The Example popup is published in our installation, and then it was also enabled. I personally turned it off, and so it never popped up since.

    I checked again for more details on the update I’ve mentioned, but wasn’t able to find more info to answer your question. Could it be a conflict with the Popup Maker – Woocommerce Pro add-on, or are the two completely independent?

    I also checked your links, and it all seems in order.

    Lastly, perhaps it could be a good idea to only display the example popup in the admin area regardless. In the front-end it gives the impression like the site has been hacked. It is rare that the styles applied will match those of most sites anyway, so it looks and feels out of place.

    Thanks again.

    Bel

    (@belimperial)

    Hi @skredlemon

    Thank you for your reply.

    We’ll ask our development team about the wp-cron, and get back to you.

    We don’t think it is because of the WooCommerce Pro extension. We have tested both the core free plugin and extension, but we did not replicate the issue.

    Thank you for your feedback. We suggest creating a feature request to update the example popup and display it to only on the administrator area.

    You can monitor the submitted feature, and get updates from our developers. You may also leave a comment in the featured request section.

    Please see it here

    https://wppopupmaker.com/your-account/feature-requests/

    We hope that helps. Please let us know if you have questions.

    Thanks!

    Plugin Support Kim L

    (@kimmyx)

    Hi @skredlemon,

    Just an update to your wp-cron query.

    Our dev team states that Popup Maker doesn’t use cron for anything other than the opt-in usage tracking which occurs once a week or so.

    Cheers!

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Spam popup after update?’ is closed to new replies.