Source Overlay not working after upgrading to 2.x

  • Resolved slaven

    (@slaven)


    4 years, 2 months ago

    Hello Thomas,

    thanks a lot for all the effort you put into this plugin. I have been using the plugin on my websites for many years now without any issues.

    Today I decided to move from v 1.x (last v1 release) to the most current 2.x version along with my upgrade to WP 5.6.

    Everything is working great besides the overlay output of the source on post images. Instead of the overlay (I had it set to top left) the source now is rendered below the images (in between image and image caption).

    I already played around with the other overlay options in the ISC admin menu, but no change in behaviour. Seems like the CSS is not even loaded?

    I also removed any custom CSS I had in place with v1.x. Still no change.

    Would really appreciate your help.

    I attached a link with a sample post showing the problem.

    Do I need to rebuild any index?

    Best,
    Nils

    The page I need help with: [log in to see the link]

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Thomas Maier

    (@webzunft)

    Hi Nils,

    thanks for being a long-term user and for giving me a chance to investigate the problem.

    I found a JavaScript issue in ISC on your site, though I cannot reproduce it. I am wondering if this has something to do with Autoptimize. Could you disable Autoptimize and check if that changes anything?

    Thanks,
    Thomas

    Thread Starter slaven

    (@slaven)

    Hallo Thomas,

    thank you for your feedback! I tried disabling CSS and/or JavaScript optimisation as well as disabling Autoptimize completely as you suggested.

    The result stayed the same. The overlay did not came back to the old 1.x design.

    Any other things I can tried to help you narrowing down the problem?

    Thanks,
    Nils

    Plugin Author Thomas Maier

    (@webzunft)

    Hi Nils,

    thanks for testing.

    I did have to dig deep, but did indeed find the issue in ISC.

    If you feel comfortable installing the fixed version from github then please test. Otherwise, I intend to release the official update later this week.

    Thanks for reporting it!

    Thomas

    Thread Starter slaven

    (@slaven)

    Hi Thomas,

    wow thank you for all your effort!

    I just tried out the fixed Git version and it seems to work perfectly again. ??

    Thanks again. Looking forward to the official release.

    Best regards,
    Nils

    Plugin Author Thomas Maier

    (@webzunft)

    Hi Nils,

    thanks for confirming the fix!

    If you enjoy ISC and want to support it then I would appreciate a positive review.

    Enjoy your weekend!
    Thomas

    Thread Starter slaven

    (@slaven)

    Done! ??

    Have a great weekend, too!

    Best,
    Nils

    Plugin Author Thomas Maier

    (@webzunft)

    > Have a great weekend, too!

    That review made sure of it ??

    Thomas

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Source Overlay not working after upgrading to 2.x’ is closed to new replies.

Tags