Some issues and a feature request

Hi Kostas,

thanks for your hints.

1. fixed this and sent you a patch to test
2. correct, I have no chance to recognize who fetchs the card online
3. fixed this and sent you a patch to test
4. you can ovewrite this by filling the field “Message to display when a card has been sent or scheduled” in the admin dialog

You can modify the form by editing the template wp-greet-form-template.php just remove

<tr class="wp-greet-form">
 <td class="wp-greet-form-left">{%ccsender_label%}:</td>
 <td class="wp-greet-form">{%ccsender_input%}</td>
</tr>

If I would add all wishes to modify the form as parameters the plugin would have hundreds of option.

Hello Hans,

Thank you for the patches, please see my test findings below:

1. %receiver% now correctly resolves to receiver, BUT confirmation email is now sent to receiver, not to sender (as before the patch).
2. OK fine.
3. Fix confirmed.
4. If I ovewrite by filling the field “Message to display when a card has been sent or scheduled” in the admin dialog, then I cannot setup second language translation with WPML. This field (and many others) should show different language contents, according to WPML current language in the admin panel (as Form-Post/Page field is correctly showing). I can help with this, if you want me to, as I have purchased WPML. Just ask.

If I remove the block you mention in wp-greet-form-template.php, then at the next plugin upgrade, this change would be lost, correct?

A simpler solution would be to give distinct class names to form items (if it does not break something else). Then by using the Appearance Customize, this Additional CSS would work, for example:

.wp-greet-form-left6 {
	display: none;
}
.wp-greet-form6 {
	display: none;
}

Cheers,
Kostas

HI Kostas,

just send you antoher patch.

1. should be fixed now
4. It seems to be a kind of missing feature in WPML. I ahve read mayn people who would like to translate origin strings with WPML too. Anyway, I now separated the messaged depending on the “send future card setting”.

I am happy with the templates, because most people change the templates anyway to ad own advertising or remove fields or embedding their own stuff. I do not think it is a benefit to have a css class for every field and it raises the traffic.

Hi Hans,

Thank you for the patch, my comments follow:

1. Fixed, confirmed.
4. I do not think it is a missing feature in WPML, as it is working at other circumstances. Anyway, the separated message depending on the “send future card setting” is working fine.

Regarding the template files, are you saying that they remain untouched during a plugin update? Or do we have to apply all changes to the template files again?

Cheers,
Kostas

Hello again Hans,

Regarding the template files, I have checked, they are overwritten during a plugin update. So all changes people have made (to add own advertising or remove fields or embedding their own stuff, as you say) are lost!

Anyway, I believe CC to sender should be an option in admin (eg with a checkbox), let alone that if the sender sees the card, the confirmation email is fired (as you have no chance to recognize who fetches the card online).

Cheers,
Kostas

• This reply was modified 7 years, 6 months ago by kostas45.