Some errors in the code — PHP 7

Thanks for letting us know @cavediver. This is from a popular PHP security library that Keyy uses.

I have let the authors know of the issue as well as submitted a patch so the next version should hopefully have the fix in it.

Warm Regards

I was just about to open the same thread.

Is there any ETA on the upcoming update that fixes this?

I will update here about an ETA soon @catmaniax. Im in touch with the developers. Just to be certain, where exactly are you getting these errors ? Are you running any unit tests with phpcs ?

Thanks

Hey,

It’s just from the report I got from the “PHP Compatibility Checker” plugin.

Hi @catmaniax and @cavediver I have confirmed that these errors can be safely ignored. Both phpseclib and Keyy are run through in-house CI that checks PHP version compatibility. So please treat this as a false positive.

See this for more information

Regards

Thanks for the reply.

I was also wondering if any updates are coming soon and if you can add a bypass link feature to the free version.

Please let me know.
Thanks.

Hi again @catmaniax

The apps are going to have much more magical animations on successful logins and also possibly a single-sign on feature, so logging into one site with Keyy logs you into all sites on that device.

Also I will pass your feedback along to have the bypass link added to the free version. I cannot commit at this point but we will certainly consider it.

Thanks again for the help in reporting this.

• This reply was modified 7 years, 3 months ago by LumberHack.

Thanks a lot ??

Is there an approximate ETA of the update?

The app related update (Android) is presently being tested and can be expected anytime this week or the next. The SSO will take longer and I cannot comment on an ETA at this point.

Warm Regards

Hi, I have some additional php 7 compatibility ‘clone’ errors as well as those detailed above. I ran a plugin called SG Optimizer provided by my host that checks for PHP 7 compatibility:
FILE: /REMOVED/wp-content/plugins/keyy/vendor/phpseclib/phpseclib/phpseclib/File/ANSI.php
—————————————————————————————————————————————–
FOUND 5 ERRORS AFFECTING 5 LINES
—————————————————————————————————————————————–
191 | ERROR | ‘clone’ is a reserved keyword introduced in PHP version 5.0 and cannot be invoked as a function (T_CLONE)
192 | ERROR | ‘clone’ is a reserved keyword introduced in PHP version 5.0 and cannot be invoked as a function (T_CLONE)
344 | ERROR | ‘clone’ is a reserved keyword introduced in PHP version 5.0 and cannot be invoked as a function (T_CLONE)
414 | ERROR | ‘clone’ is a reserved keyword introduced in PHP version 5.0 and cannot be invoked as a function (T_CLONE)
433 | ERROR | ‘clone’ is a reserved keyword introduced in PHP version 5.0 and cannot be invoked as a function (T_CLONE)
—————————————————————————————————————————————–

FILE: /REMOVED/wp-content/plugins/keyy/vendor/phpseclib/phpseclib/phpseclib/File/X509.php
—————————————————————————————————————————————–
FOUND 4 ERRORS AFFECTING 4 LINES
—————————————————————————————————————————————–
4660 | ERROR | Using a call-time pass-by-reference is deprecated since PHP 5.3 and prohibited since PHP 5.4
4685 | ERROR | Using a call-time pass-by-reference is deprecated since PHP 5.3 and prohibited since PHP 5.4
4752 | ERROR | Using a call-time pass-by-reference is deprecated since PHP 5.3 and prohibited since PHP 5.4
4824 | ERROR | Using a call-time pass-by-reference is deprecated since PHP 5.3 and prohibited since PHP 5.4
—————————————————————————————————————————————–

FILE: /REMOVED/wp-content/plugins/keyy/vendor/phpseclib/phpseclib/phpseclib/Net/SFTP/Stream.php
———————————————————————————————————————————————–
FOUND 1 ERROR AFFECTING 1 LINE
———————————————————————————————————————————————–
200 | ERROR | Global with variable variables is not allowed since PHP 7.0
———————————————————————————————————————————————–