Solved: Holding Shift Misbehaviour

Hello,

I was noticing that if a user holds shift, it causes the search window to rapidly toggle in an out of existence. I did some research and experimentation and found that the solution is to change your Mousetrap.bind call in acp-modal.js to include a ‘keyup’ argument:

Mousetrap.bindGlobal('shift shift', function() {
	AcpModal.toggle();
}, 'keyup');

I then updated this in admin.js and admin.min.js and it works perfectly. Holding shift does nothing, while pressing it twice brings up the search bar.

I hope this is helpful!

(This is also a great way for developers to change their keyboard shortcut if they hate pressing shift for some reason. Just search for “shift shift” in admin.min.js and change it to whatever key sequence you desire. Perhaps something like ‘ctrl+shift+f’ would be more familiar.)