Signature doesn't filter out malicious html
-
Hello,
Because of BBCode parsing issues I switched our system to use HTML mode. I wanted to bring this to your attention.
I notice if I did a signature like
<strong onclick="alert('I am evil');">Some words</strong>
That it would run the javascript on the page.
I modified the format signature to run wp_kses to hopefully catch more javascript issues
public function format_signature($sig) { if ($this->method != 'html') { $sig = strip_tags($sig); } if ($this->method != 'bbcode') { $sig = strip_shortcodes($sig); $sig = wp_kses($sig, wp_kses_allowed_html('post')); } if (strlen($sig) > $this->max_length) { $sig = substr($sig, 0, $this->max_length); } return trim($sig); }
That seems to filter it now. Just wanted to bring it to your attention.
- The topic ‘Signature doesn't filter out malicious html’ is closed to new replies.