Show popup by clicking on a link AT ANY TIME

@dejudicibus – I assume this was the same issue as emailed to our support. The resolution is to use the popmake_popup_data_attr filter instead and unset the $data[‘meta’][‘auto_open’] key for all but one.

Hope this helps.

@dejudicibus – I assume this was the same issue as emailed to our support. The resolution is to use the popmake_popup_data_attr filter instead and unset the $data[‘meta’][‘auto_open’] key for all but one.

Hope this helps.

Yes, I am looking with Daniel about that, but there is still something that does not work. I used this filter

if( ! function_exists('rfa_theme_popup_data_attr') ){
	function rfa_theme_popup_data_attr( $data_attr, $popup_id ) {
		$popups = array(
			6003 => array( 'start' => '08:00', 'end' => '10:00' ),
			6019 => array( 'start' => '10:00', 'end' => '13:00' ),
			6625 => array( 'start' => '13:00', 'end' => '16:00' ),
			6024 => array( 'start' => '16:00', 'end' => '20:00' ),
			6026 => array( 'start' => '20:00', 'end' => '08:00' )
		);
		foreach( $popups as $id => $times ) {
			if ( $id == $popup_id && isCurrentTimeBetween( $times['start'], $times['end'] ) ) {
				$data_attr['meta']['auto_open'] = popmake_get_popup_auto_open( $popup_id );
			} else {
				unset( $data_attr['meta']['auto_open'] );
			};
		}
		return;
	}
	add_filter( 'popmake_get_the_popup_data_attr', 'rfa_theme_popup_data_attr', 100, 2 );
}

but it does not work. The auto-load does not work anymore and clicking on buttons does not work too.

@dejudicibus – Looks like you forgot to return $data_attr.

You are currently returning null to a filter so the data_attr passed to the Popup is empty at this point. Hope that helps.

what should I return? just data_attr?

return $data_attr;

?

@dejudicibus – Correct. A filter in wordpress should always return the same variable passed as the first parameter. You are filtering the content of that variable. In this case the data_attr. If you don’t return then the next filter or the variable that your filters were applied to will then become empty/invalid.

$var = apply_filters( ‘filter_name’, $var );

So if you don’t return the $var in your filter, our $var = null.

Hope that helps.

It does. By adding

return $data_attr;

the buttons allow me to manually open the popup, but the pop-up that has to be opened automatically is not opened anymore. I wonder why… ??

@dejudicibus – One thing that may be tripping you up is that your popups are setting a cookie. Once set the popup won’t open again until it expires or you clear cookies. If one should be open at all times then disable cookies under auto open for all popups. If you want it to show once per visit use session cookies and leave the cookie trigger.

Hope that helps.

Well, I think that the cookie should apply ONLY to auto-open, not to manual call. If you link the cookie to a popup, it applies to both. The cookies should prevent to re-open the same popup each time you reload the corresponding page, but manual calls through buttons or links should be managed differently.

@dejudicibus – Click triggers do no check for cookies. In the new version v1.4 that is possible, but only if you explicitly set it up. in v1.3.9 that is not possible without writing your own JS to check the cookie and trigger on click.

What I meant before was that your popups are likely set under Auto Open to set a cookie either “On Open” or “On Close” that means if the popup auto opened one time and you closed it then the cookie is set. Any refreshes after that will not trigger the popup until the cookie expires or the cookies are cleared.

Also in v1.4 you can assign multiple cookies, custom cookie names and even check for cookies set by other plugins, themes or core WP.

OK, can you please check if a popup appears as you go to https://academy.romafilm.it/ ?

I reset all cookies’ keys, and changed cookie time to 1 hour, so that it expires if you come back to the site after a hour or more.

Now all popups appears if you click on circled number buttons on the left sidebar, but I am not sure that they appears too automatically.

Popups are intended only on the cover page.

It looks like it does not work. I removed all cookies but there is no more automated popup if I use:

if( ! function_exists('rfa_theme_popup_data_attr') ){
	function rfa_theme_popup_data_attr( $data_attr, $popup_id ) {
		$popups = array(
			6003 => array( 'start' => '07:00', 'end' => '09:00' ),
			6789 => array( 'start' => '09:00', 'end' => '12:00' ),
			6019 => array( 'start' => '12:00', 'end' => '14:00' ),
			6625 => array( 'start' => '14:00', 'end' => '17:00' ),
			6024 => array( 'start' => '17:00', 'end' => '20:00' ),
			6026 => array( 'start' => '20:00', 'end' => '07:00' )
		);
		foreach( $popups as $id => $times ) {
			if ( $id == $popup_id && isCurrentTimeBetween( $times['start'], $times['end'] ) ) {
				$data_attr['meta']['auto_open'] = popmake_get_popup_auto_open( $popup_id );
			} else {
				unset( $data_attr['meta']['auto_open'] );
			};
		}
		return $data_attr;
	}
	add_filter( 'popmake_get_the_popup_data_attr', 'rfa_theme_popup_data_attr', 100, 2 );
}

PS I am using 1.3.9.
PPS I am using “On Close” for popups

@dejudicibus – I get a popup currently when I clear cookies. And all work with click.

I think what is happening is that when you click the close button even for the click opened ones it is setting the cookie. Though it should have auto opened before you have a chance to click them.

All in all only one popup is coming up with auto open settings and has a timer of 1 hour. Cookie looks correct as well.

Seems to be working correctly, maybe try clearing site cache and using a private browser session.

That’s curious. I tried from both laptop and mobile phone, but I cannot see any popup when I load the home page!