Shortcoder Menu Shortcoder Bug

Hi @dailycdev,

Thanks for your time in gathering the details.

Shortcoder does not have any limits in the code size. I’ve tested the plugin with even bigger code and they work.

After upgrading to v5+ did you try pasting the full code into the the “visual editor” manually and save it ?

Since the code is huge, there could be problem with automatic migration.

In your staging site, you can try the following:

1) While in V4, copy the huge shortcode content which is not working as a backup.

2) Upgrade to V5

3) Paste the shortcode content manually in the visual editor and save the shortcode.

4) See if the entire content is saved as expected in v5. If yes, then whatever you’ve saved will be there in the output. Shortcoder does not manipulate with the code.

Thanks,
Aakash

I found the issue…

Your plugin is converting the following code upon upgrading to v5 and higher…
<select class=”chosen” onchange=”location = this.value;”>

To:

<select class=”chosen”>

And…

<option selected=”true” disabled=”disabled”>Select Chapter</option>

To:

<option selected=”true”>Select Chapter</option>

See below…
——————-
Original Code in Shortcode, using v4.6
——————-
<style>
.myDi1v{
display:none;
}
</style>
[noindex]
<div class=”bbooks”>
<select id=”myselectio1n” class=”chosen”>
<option selected=”true” disabled=”disabled”>Select Book</option>
<option value=”1″/>Genesis</option>
<option value=”2″/>Exodus</option>
</select>
</div>
<div id=”sho1w1″ class=”myDi1v”>
<select class=”chosen” onchange=”location = this.value;”>
<option selected=”true” disabled=”disabled”>Select Chapter</option>
<option value=”/bible/genesis/genesis-1/”>1</option>
<option value=”/bible/genesis/genesis-2/”>2</option>
<option value=”/bible/genesis/genesis-3/”>3</option>
<option value=”/bible/genesis/genesis-4/”>4</option>
<option value=”/bible/genesis/genesis-5/”>5</option>
<option value=”/bible/genesis/genesis-6/”>6</option>
<option value=”/bible/genesis/genesis-7/”>7</option>
<option value=”/bible/genesis/genesis-8/”>8</option>
<option value=”/bible/genesis/genesis-9/”>9</option>
<option value=”/bible/genesis/genesis-10/”>10</option>
</select>
</div>
<div id=”sho1w2″ class=”myDi1v”>
<select class=”chosen” onchange=”location = this.value;”>
<option selected=”true” disabled=”disabled”>Select Chapter</option>
<option value=”/bible/exodus/exodus-1/”>1</option>
<option value=”/bible/exodus/exodus-2/”>2</option>
<option value=”/bible/exodus/exodus-3/”>3</option>
<option value=”/bible/exodus/exodus-4/”>4</option>
<option value=”/bible/exodus/exodus-5/”>5</option>
<option value=”/bible/exodus/exodus-6/”>6</option>
<option value=”/bible/exodus/exodus-7/”>7</option>
<option value=”/bible/exodus/exodus-8/”>8</option>
<option value=”/bible/exodus/exodus-9/”>9</option>
<option value=”/bible/exodus/exodus-10/”>10</option>
</select>
</div>
——————-
Modified by your plugin upon conversion to from v4.6 to v5.3.1
——————-
<style>
.myDi1v{
display:none;
}
</style>
[noindex]
<div class=”bbooks”>
<select id=”myselectio1n” class=”chosen”>
<option selected=”true”>Select Book</option>
<option value=”1″ />Genesis</option>
<option value=”2″ />Exodus</option>
</select>
</div>
<div id=”sho1w1″ class=”myDi1v”>
<select class=”chosen”>
<option selected=”true”>Select Chapter</option>
<option value=”/bible/genesis/genesis-1/”>1</option>
<option value=”/bible/genesis/genesis-2/”>2</option>
<option value=”/bible/genesis/genesis-3/”>3</option>
<option value=”/bible/genesis/genesis-4/”>4</option>
<option value=”/bible/genesis/genesis-5/”>5</option>
<option value=”/bible/genesis/genesis-6/”>6</option>
<option value=”/bible/genesis/genesis-7/”>7</option>
<option value=”/bible/genesis/genesis-8/”>8</option>
<option value=”/bible/genesis/genesis-9/”>9</option>
<option value=”/bible/genesis/genesis-10/”>10</option>
</select>
</div>
<div id=”sho1w2″ class=”myDi1v”>
<select class=”chosen”>
<option selected=”true”>Select Chapter</option>
<option value=”/bible/exodus/exodus-1/”>1</option>
<option value=”/bible/exodus/exodus-2/”>2</option>
<option value=”/bible/exodus/exodus-3/”>3</option>
<option value=”/bible/exodus/exodus-4/”>4</option>
<option value=”/bible/exodus/exodus-5/”>5</option>
<option value=”/bible/exodus/exodus-6/”>6</option>
<option value=”/bible/exodus/exodus-7/”>7</option>
<option value=”/bible/exodus/exodus-8/”>8</option>
<option value=”/bible/exodus/exodus-9/”>9</option>
<option value=”/bible/exodus/exodus-10/”>10</option>
</select>
</div>

Strange why disabled=”disabled” is missing.

There is no such code in Shortcoder to do the same.

Glad that you found the issue.

You can replace the shortcode content in v5 with the original and things should be fine.

Based on what I just posted, why is your plugin stripping code from my shortcodes? Because of this, I feel like I cannot trust upgrading to the latest version since many other pages with code in their shortcodes would also be manipulated and possibly not work. So please consider fixing this. Stripping code off like wordpress.com used to do to me until I moved to www.remarpro.com was terrible.

Your plugin is converting the following code upon upgrading to v5 and higher…
<select class=”chosen” onchange=”location = this.value;”>
To:
<select class=”chosen”>

And this brakes all the menus on my site.
Please update your plugin to not remove code in the shortcodes.
Thanks.
-Paul

Your plugin is also converting the following…
<option selected=”true” disabled=”disabled”>Select Chapter</option>
To:
<option selected=”true”>Select Chapter</option>

Hopefully, an update will come out that will fix the stripping of code off, when going from v4.6 to v5 and higher.

I went ahead and backed up every shortcode, then upgraded the plugin to the current version and went into code editor and fixed every shortcode, since most of them had pieces of code stripped out like <script> and more. In saying this, I hope this issue gets fixed for the future.

@dailycdev,

Shortcoder does not remove them.

Also there is no need for Shortcoder to specifically remove them either.

It should be because of someother plugin stripping off the attributes and keep the remaining for some security/safety checks.

If I could get the list of plugins active I could guess what could be causing this.

Thanks,
Aakash

I appreciate you giving me the idea to do the following…
“You can replace the shortcode content in v5 with the original and things should be fine.”

That was what fixed my issue.
And a couple new ideas I found for a new version is the following…
* Add a Date Modified Column, so we can see the shortcodes that have recently been modified.
* Add an automated tag for shortcodes with errors in them. You can name the tag “Error” and auto tag shortcodes with it. This would be helpful to know what shortcodes I need fixed.

Anyhow, thanks again for making a very good plugin that is essential for wordpress.
-Paul