Select Field Sortable / Ajax bugs

  • Resolved spoonthemes

    (@spoonthemes)


    4 years, 3 months ago

    Hi guys.

    1. There are extra ” onlines 26 https://prnt.sc/tsmaw6 and 128 https://prnt.sc/tsmaqb which stops sortable function for the select field wp-content\plugins\redux-framework\redux-core\inc\fields\select\class-redux-select.php

    2. ajax option does not work correctly.

    a. when typing is finished and query sent https://prnt.sc/tsmqw8 this code executes 3 times https://prnt.sc/tsmr2c ( \wp-content\plugins\redux-framework\redux-core\inc\classes\class-redux-wordpress-data.php ) and 3rd time value for taxonomies becomes empty https://prnt.sc/tsmsa2 so all terms from all taxonomies are returned

    b. Once the data is fetched and sent to \wp-content\plugins\redux-framework\redux-core\inc\classes\class-redux-ajax-select2.php wrong term_id is sent back to the frontend because of array_values( $return ) https://prnt.sc/tsmusc array_values() is not needed since $return is already array with array keys set to term_ids ( array_values() changes array keys )

    Thanks

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor Dōvy Paukstys

    (@dovyp)

    Hey there! Good catch. Have you tested if those two double quotes are removed, does the problem go away?

    I’ve removed the extra quotes in the repo. The change will go out on the next release. Let me know if that fixes the issue for you. Thank you.

    Thread Starter spoonthemes

    (@spoonthemes)

    Hi Dōvy

    Yes if quotes are removed sortable is working without issues

    Regards.

    Plugin Contributor Dōvy Paukstys

    (@dovyp)

    Fantastic. It’s been pushed as 4.1.9 without a version increase. Trying to fix a few more things before the next release. ??

    Tell your users to delete and reinstall for the fix. Thanks!

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Select Field Sortable / Ajax bugs’ is closed to new replies.