Search Results Yield Draft Posts

Try adding this to your theme functions.php:

add_action( 'plugins_loaded', 'rlv_rcp_fix' );
function rlv_rcp_fix() {
    remove_filter( 'relevanssi_post_ok', 'relevanssi_restrictcontentpro_compatibility', 10, 2 );
}

add_filter( 'relevanssi_post_ok', 'rlv_restrictcontentpro_compatibility', 10, 2 );
function rlv_restrictcontentpro_compatibility( $post_ok, $post_id ) {
	$status = relevanssi_get_post_status( $post_id );
	if ( 'publish' === $status ) {
		$post_ok = rcp_user_can_access( get_current_user_id(), $post_id );
	}
	return $post_ok;
}

Does that solve the problem?

Hi Mikko,

Thank you for the suggestion to try the code in the functions.php file. We tried it out but, unfortunately, it did not fix the issue for us. However, we had also written to Restrict Content Pro yesterday about this same issue and they replied with the following:

I’ve looked into this and it’s an issue with Relevanssi’s Restrict Content Pro integration. When determining whether or not a post should be visible, they normally check things like if the post is a draft, etc. However, in their RCP integration, they just check RCP’s rcp_user_can_access() function and use that as the master determination of whether or not a post should appear in the archive. However, that function of ours ONLY checks restriction permissions. So essentially what’s happening here is that if a user has RCP’s permission to view a post, then Relevanssi is including it. They’re not combining that with their normal checks, which is what they should be doing.

If you’d like to pass this information along to them, the problem is in their file relevanssi/lib/compatibility/restrictcontentpro.php. Their function is currently like this:

function relevanssi_restrictcontentpro_compatibility( $post_ok, $post_id ) {
	$post_ok = rcp_user_can_access( get_current_user_id(), $post_id );

	return $post_ok;
}

One possible fix would be to adjust it like so:

function relevanssi_restrictcontentpro_compatibility( $post_ok, $post_id ) {
	if ( ! $post_ok ) {
		return $post_ok;
	}

	$post_ok = rcp_user_can_access( get_current_user_id(), $post_id );

	return $post_ok;
}

That makes it so if the user doesn’t meet the BASE requirements (checking draft status, etc.) then the user can’t view it. If the user does meet those requirements, then it proceeds to check RCP content restrictions and use those.

We tried out this code ourselves in this /wp-content/plugins/relevanssi/lib/compatibility/restrictcontentpro.php file and it worked immediately—draft posts no longer showed up in search results.

Can this fix please be implemented in the next Relevanssi plugin update and, if so, is there an ETA on that update? In the meantime, we’ll simply keep Restrict Content Pro’s fix in the restrictcontentpro.php file. But, of course, this is not ideal as we’ll need to manually re-implement this fix after each Relevanssi update if the fix is not incorporated.

Thank you!
Nicolas from Living Miracles

This fix will be incorporated in the next version. Don’t know when that is, but since you have a working fix and won’t have to worry about the updates, that shouldn’t be a problem.

(Their fix does essentially the same thing my fix does, so strange that that didn’t work.)

Hi Mikko,

That’s great, thank you!

Nicolas from Living Miracles

Hi Mikko
I have been facing the same issue. Let me explain. I have 321 posts where 320 is published and 1 is draft. But when I search I can see the result is showing 321 posts. I tried with the solution in this post but got error. Uncaught Error: Call to undefined function rcp_user_can_access()