Search box no longer displays correctly

Hello Tony,

Thanks for reaching out. Sorry to hear something went wrong as part of the upgrade to 1.8.

There is no obvious reason why that would happen so let me try to understand a bit better. Did this happen straight after you upgraded to 1.8 ?

When I look at the rendered HTML, the CSS shows no value is passed through “#searchboxInc_22828 form {background: #;}”. It should say “#searchboxInc_22828 form {background: #FEBA02;}”. Same goes for the other cues.
Does Searchbox “22828” has the color coding parameters setup correctly when you look at the admin page ?

Let me know how things look.
Greg

Hi Greg, thanks for replying. It seems to have happened after the 1.8 upgrade but I can’t be sure. Could also be related to the WP 4.1.1 upgrade.

Everything looks good at the admin end but of course you cannot preview the search box from there. Colors are all in specified. But I don’t think ANY parameters are being passed to the form at all.

However, I did create a new search box (23069) for that page and it’s working fine. So it seems to be having problems dealing with search boxes created using the previous version of the plugin. This is a pity because I have about 50 of those.

Also, have you looked at allowing defaults to be set for this plugin? It would be great if each of the fields in the form could have a default value so when you create a new search box you only need to set the destination. I had modified mine to do this in 1.7 but the upgrade wiped my mods.

Tony

Actually I think that was a coincidence. I tried replacing the search box in https://www.travelnasia.com/china/great-wall-china-simatai/ with a new one but it still doesn’t work. No idea what the difference is (although the first URL is a blog post, while this URL is a custom place post).

What you sent is very insightful… but I really can’t think of a good solid reason for this. Searchboxes are tested (and do work) for custom-post types too (i.e. Templatic’s Directory theme).

Let me think about it and come back to you. Till then, any other observation would be great.

Hi Greg, have you had a chance to think about this yet? I’m getting a bit desperate for a solution.

Tony

Hi Greg, thanks for replying. It seems to have happened after the 1.8 upgrade but I can’t be sure.

Everything looks good at the admin end but of course you cannot preview the search box from there. Colors are all specified. But I don’t think ANY parameters are being passed to the form at all.

I have tried creating a new search box and it has the same issues. I’ve also tried disabling all other plugins, but it doesn’t help.

Also, have you looked at allowing defaults to be set for this plugin? It would be great if the key fields in the form (e.g. Affiliate ID) could have a default value so when you create a new search box you only need to set the destination. I had modified mine to do this in 1.7 but the upgrade wiped my mods and now I have to do it each time again.

Tony

Hey Tony,

If you switch back to 1.7, is everything back in order ?
Let me know… that’d help in rootcausing !

Thanks
Greg

It doesn’t seem so Greg. I have replaced 1.8 with 1.7 and it still seems to be the same. Maybe you could take a look as perhaps I’m cached. Try https://www.travelnasia.com/china/xian-china-destination-guide/ down near the bottom of the page.

If it was only CSS issues I might blame my theme, but the fact that plugin-generated data is not getting through seems really strange.

Tony

I’ve done a bit more debugging on my test site and I notice if I switch to 2014 theme I am seeing a lot of error messages just above the hotel search box like:

Find and book great hotels in Beijing

Notice: Undefined offset: 0 in /home/asiantra/public_html/travelnasia.test/wp-includes/query.php on line 3680

Notice: Trying to get property of non-object in /home/asiantra/public_html/travelnasia.test/wp-includes/query.php on line 4553

Notice: Trying to get property of non-object in /home/asiantra/public_html/travelnasia.test/wp-includes/query.php on line 4555

Notice: Trying to get property of non-object in /home/asiantra/public_html/travelnasia.test/wp-includes/query.php on line 4557

Notice: Trying to get property of non-object in /home/asiantra/public_html/travelnasia.test/wp-includes/query.php on line 4558

Notice: Trying to get property of non-object in /home/asiantra/public_html/travelnasia.test/wp-includes/query.php on line 4569

Notice: Trying to get property of non-object in /home/asiantra/public_html/travelnasia.test/wp-includes/query.php on line 4577

Notice: Trying to get property of non-object in /home/asiantra/public_html/travelnasia.test/wp-includes/query.php on line 4594

The search box does not display properly in this theme either. When I deactivate the plugin, the error messages disappear and I am left with just the shortcode for the search box, so I’m thinking these messages are connected to the display problem.

Line 3680 calls $this->post
Line 4553 assigns $post->id to $id
Line 4555 gets the post author details
4557 and 4558 get the current day and month
4569 determines the post type
4577 populates the post content
4594 creates the post content array

So I’m thinking that if your plugin is using hooks into these, that’s where I’d expect to find the problem. But why? Why just my website?

Hello Tony,

Yes, the plugin uses the standard WP hooks… Really scrathing my head here. This happened the minute you switched to 1.8 ?

#NotGivingUp
Greg

The connection between upgrading and the problem might not be that clear. I only noticed it being a problem after I upgraded to 1.8. But given that downgrading to 1.7 didn’t fix the problem, I’m not sure the connection is so strong. May have become a problem after a WP upgrade (there seem to have been a lot of those this year). I have not upgraded to WP 4.2 yet.