Saving data from form to Database Table

@joyously @bcworkz yeah the mysqli was misspelt but I amended that earleir, not that it made any difference lol.

no the way it was shown in the question was wrong, I tried to edit but was too late. I had added ” to the terms in the brackets on the lower one but all it done was add grey areas lol… And this is one big grey area for me

I feel as though I have used the correct code I cannot see anything that I should change.
But I am unsure how to determine what is causing the error.

When I check console and params, it gives all the right parameters with the correct titles.

But the php doesnt seem to take them and insert them into the table. I am unsure how to debug this as the echo statements I have added dont seem to work which makes it harder to determine where the error lies

Anything echoed in an ajax call comes back in the response.
You should use the PHP error_log function.

@joyously @bcworkz yeah the mysqli was misspelt but I amended that earleir, not that it made any difference lol.

I now have error messages showing…

Have done a bit of tinkering and the error message I am getting:

Error: INSERT INTOadd_job(id,adddate,addcontact,adda,addb,addincome,addpayment,addsubbie,addclient`) VALUES (NULL ‘2019-09-06’, ‘test’, ‘test’, ‘test’, ‘test’, ‘test’, ‘test’, ”)
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ”2019-09-06′, ‘test’, ‘test’, ‘test’, ‘test’, ‘test’, ‘test’, ”)’ at line 2`

I have changed to code to:

JS

    jQuery(document).ready(function () {
    $("#addsubmit").click(function(e) {
        e.preventDefault();
        e.stopPropagation();

        var date = document.getElementById("adddate").value;
        var contact = document.getElementById("addcontact").value;
        var a = document.getElementById("adda).value;
        var b = document.getElementById("addb").value;
        var income = document.getElementById("addincome").value;
        var payment = document.getElementById("adddate").value;
        var subbie = document.getElementById("addsubbie").value;
        var client = document.getElementById("addclient").value;

        // Returns successful data submission message when the entered information is stored in database.
        var dataForm = 'date1=' + date + '&contact1=' + contact + '&a1=' + a + '&b1=' + b + '&income1=' + income + '&payment1=' + payment + '&subbie1=' + subbie + '&client1=' + client;
        if (date == '' || contact == '' || a == '' || b == '' || income == '' || payment == '' || subbie == '' || client == '') {
        alert("Please Fill All Fields");
        } 
        else {
        // AJAX code to submit form.
            jQuery.ajax({
                type: "POST",
                url: 'wp-content/themes/EazyFreight/database.php',
                data: dataForm,
                dataType:"json", 
                success:function(strMessage) {
                    $("#message").text(strMessage);
                    $("#dataForm")[0].reset();
                }
            });
            return false;  
        }
    });

PHP

<?php

    //Register variables
    $adddate = $_POST['date1'];
    $addcontact = $_POST['contact1'];
    $adda = $_POST['a1'];
    $addb = $_POST['b1'];
    $addincome = $_POST['income1'];
    $addpayment = $_POST['payment1'];
    $addsubbie = $_POST['subbie1'];
    $addclient = $POST['client1'];

    //connect with Database
    if (!empty($adddate) || !empty($addcontact) || !empty($adda) || !empty($addb) || !empty($addincome) || !empty($addpayment) || !empty($addsubbie) || !empty($addclient)){
        $host_name = 'xxx.hosting-data.io';
        $database = 'xxx';
        $user_name = 'xxx';
        $password = 'xxx';
        $conn = mysqli_connect($host_name, $user_name, $password, $database);
    }
    // Check connection

    if (!$conn) {
        die("Connection failed: " . mysqli_connect_error());
    }

    $sql = "INSERT INTO <code>add_job</code>(<code>id</code>, <code>adddate</code>, <code>addcontact</code>, <code>adda</code>, <code>addb</code>, <code>addincome</code>, <code>addpayment</code>, <code>addsubbie</code>, <code>addclient</code>)
    VALUES (NULL '$adddate', '$addcontact', '$adda', '$addb', '$addincome', '$addpayment', '$addsubbie', '$addclient')";
    
    if (mysqli_query($conn, $sql)) {
        echo "New record created successfully";
    } 
    else {
        echo "Error: " . $sql . "<br>" . mysqli_error($conn);
    }
    mysqli_close($conn);
    die();

Have you any idea what might cause the error? or the best way to deb

You are going to have to read the error and do what it says. There is a missing comma after NULL in your SQL. Not sure what else.

@joyously
Simple fix, thank you, thats it working now ??

In all honesty in the few replies youve given me you have been a massive help… You have helped me to also see that when I am debugging I spend too much time looking at the code and what it is saying as above, my code seemed to have all the right info etc… I dont spend enough time looking at the other details such as punctuation which can have a massive effect on the code.

I looked at that over and over and never noticed the missing ,

Thank you again and sorry for my negligence ?? lol

Now you can focus on plugging the security holes that are in your code.
You need to sanitize all user input, validate that it is the correct type for the field, and use prepare on your SQL. Also, use of a nonce and checking for user capability to write to the database would be good, but your code is outside of WP.
With a PHP file sitting on your server, anyone can invoke it directly, especially if the checks are in some other file.

@joyously @bcworkz Thank you for the help. The form is intended to be used internally and only logged-in users within the company will have access so im hoping that security won’t be an issue.

Can I ask, I have tried a number of different things but apparently none of them being the right thing.

based on the code, I have… After form submission, I am keen for the form to be cleared however as it stands, once submitted, all of the form fields remain populated.

The jQuery/Ajax, passes all the details over for PHP to process so I am thinking that PHP will be the better place to put the code…

I have tried adding at the end:

echo:"<script></script>"

and putting different code in after the

if (mysqli_query($conn, $sql)) {
        echo "New record created successfully";
    } 

as well as after the ajax:

success: function() {
                    alert('Message sent');
                    document.getElementById('dataForm').reset();
                }

Is there a better way to do this that might actually work? lol

Update…

Solved the problem..

success: function() {
                    alert('Message sent');
                },
                complete: function(){
                    $('#dataForm').each(function(){
                        this.reset();   //Here form fields will be cleared.
                    });
                }

The bit that I cant get to clear is the <select> areas, they remain populated. however if I fill in the other areas and then press submit, although they have values in them, the script doesn’t recognsise that theyre there so I need to clear the values myself and re-enter

• This reply was modified 5 years, 6 months ago by Supplement Genie.
• This reply was modified 5 years, 6 months ago by Supplement Genie.
• This reply was modified 5 years, 6 months ago by Supplement Genie.
• This reply was modified 5 years, 6 months ago by Supplement Genie.

The form is intended to be used internally and only logged-in users within the company will have access so im hoping that security won’t be an issue.

The whole point of a hack is to do something unintended.

With a PHP file sitting on your server, anyone can invoke it directly, especially if the checks are in some other file.