Save a new action on a form -> calls save_admin() on null

The error in question here is that $data passed to save_admin() contains a property settings that has already been coerced into a string but should be an array.

This happens in admin/save.php when esc_html() is run indiscriminately over all $_POST values (error_log call is mine):

foreach ( $_POST as $key => $val ) {
        if ( substr($key, 0, 1) != '_') {
                $data_array[$key] = esc_html($val);
                error_log(sprintf('NF POST val before: %s, val after: %s', print_r($val, true), print_r($data_array[$key], true)));
        }
}

The result being:

[10-Mar-2020 09:17:38 UTC] NF POST val before: Array
(
    [name] => Redirect
    [type] => redirect
    [from_name] => 
    [from_address] => 
    [to] => 
    [email_subject] => 
    [email_message] => 
    [attach_csv] => 0
    [email_format] => html
    [reply_to] => 
    [cc] => 
    [bcc] => 
    [redirect_url] => https://domain.com
    [success_msg] => 
)
, val after: Array

• This reply was modified 4 years, 12 months ago by kwisatz.
• This reply was modified 4 years, 12 months ago by kwisatz. Reason: Style
• This reply was modified 4 years, 12 months ago by kwisatz. Reason: remove medium sensitive information

Unfortunately that’s not the only problem.
The notification object retrieved in notifications.php has an empty type property:

NF_Notification Object
(
    [id] => 29
    [type] => 
    [active] => 1
    [form_id] => 28
)

This plug-in currently is way too broken for us to monkey-patch. The developers should release a fixed version and that soon.

The issue that you are seeing is due to using the deprecated 2.9.x codebase. You can upgrade to the 3 codebase by following this documentation: https://ninjaforms.com/docs/conversion/

Thanks @jmcelhaney that did the trick indeed.
Apologies are in order in that case. The thing is, I saw that message about “Ready to upgrade to version 3” but I did not at all connect it to the problems. To me that was an upcoming new release of the plug-in, not something that was already installed and that I’d have to convert/migrate to.

On the other hand… now I have neither contact form, nor events… this seems to clash with The Events Calendar plug-in ??
But it seems to be TEC’s fault. Or the original theme author’s…

• This reply was modified 4 years, 11 months ago by kwisatz.

Same problem here… But right now, I can’t update to 3 codebase as it will require some extra work that I can’t do this week. But I need the plugin to work.

As you allow us to use 2.9 codebase, could you please correct this function to work with 3 AND 2.9 ?

Thank you!

I have the same problem. I tried to update NF to 3 but nothing happens after I click on “Start Upgrade”.

Please, what could be the issue?

I have this error:

Fatal error: Uncaught Error: Call to a member function save_admin() on null in C:\xampp\htdocs\iron_monk\wp-content\plugins\ninja-forms\deprecated\classes\notifications.php:324 Stack trace: #0 C:\xampp\htdocs\iron_monk\wp-content\plugins\ninja-forms\deprecated\includes\admin\save.php(109): NF_Notifications->save_admin(22, Array) #1 C:\xampp\htdocs\iron_monk\wp-includes\class-wp-hook.php(287): ninja_forms_admin_save(”) #2 C:\xampp\htdocs\iron_monk\wp-includes\class-wp-hook.php(311): WP_Hook->apply_filters(NULL, Array) #3 C:\xampp\htdocs\iron_monk\wp-includes\plugin.php(478): WP_Hook->do_action(Array) #4 C:\xampp\htdocs\iron_monk\wp-admin\admin.php(170): do_action(‘admin_init’) #5 {main} thrown in C:\xampp\htdocs\iron_monk\wp-content\plugins\ninja-forms\deprecated\classes\notifications.php on line 324

Is NinjaForms here? I have the problem with the latest version of NinjaForms, but with codebase 2.9.x. But if you allow people to use 2.9.x codebase, you should fix this…

Thank you in advance,
Cedric

• This reply was modified 4 years, 5 months ago by Ced.