Sale tag missing when using ‘Current discount tier’ display

  • Resolved Rune Rasmussen

    (@syntaxerrorno)


    1 year, 1 month ago

    The Sale tag is missing when selecting ‘Show sale tag and discounted price as: Current discount tier’ in ‘YayCommerce -> YayPricing -> Settings -> Product sale display’.

    It’s happening everywhere, product listings, widgets and details.

    Also we only want to display the lowest available price, for both the ordinary and discount price on variable products.

    Normally we can use t.ex. the following code to achieve this, but it doesn’t work with YayPricing as we can see on the image above…

    add_filter('woocommerce_variable_price_html', 'woo_only_display_lowest_prices_for_variable_products', 10, 2); 

function woo_only_display_lowest_prices_for_variable_products( $price, $product ) { 
     $price = '';
     return $price .= wc_price( wc_get_price_including_tax( $product ) );
}

    Both issues tested in both Storefront and Flatsome.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Support alina98

    (@alina98)

    Hi @syntaxerrorno,

    Thanks for reaching out!

    Please let me check with the dev and I will feed you back as soon as possible.

    Kind regards,
    Alina

    Plugin Support mialewp

    (@mialewp)

    Hello?@syntaxerrorno,

    Thanks for your patience.

    1. Please fix the “sale tag” issue temporarily by following this instruction https://tppr.me/hD0cnj

    We will release this fix in the next version, FYI.

    2. We are investigating this and will provide a hook for you to achieve it soon, please be patient.

    We will get back to you as soon as possible.

    Many thanks!

    Mia

    Thread Starter Rune Rasmussen

    (@syntaxerrorno)

    Thanks for following up on this.

    But first of, please add full path to the file in question when proposing fixes, not just the name. You have a complex plugin and file structure, thus it requires some digging to find it in /wp-content/plugins/yaypricing/includes/core/sale-display/class-yaydp-product-sale.php ??

    Secondly this change doesn’t do anything. The setting only displays sale tag and discount for products being in the cart, every other products would still have no sale tag/price display, which doesn’t make any sense for a global discount. Having it as a global setting makes no sense to me…

    Using those other available options just makes it look weird, for a global percentage discount.

    ‘Show sale tag and discount price as: Current discount tier’:
    *The one displaying sale tag/price is in cart, but rest also have the same 20% global discount.

    ‘Show sale tag and discount price as: Discountable price range’:
    *It’s not a price range when it’s 20% of on all, there should be just one price.

    ‘Show sale tag and discount price as: Next discount tier as if 1 more item is added’:

    But of course, if/when we get a solution to just display the lowest price for variable products (preferably as a setting), the ‘Show sale tag and discount price as: Next discount tier as if 1 more item is added’ setting probably will probably work fine. ??

    Thread Starter Rune Rasmussen

    (@syntaxerrorno)

    Any news/progress on this one? ??

    Plugin Support mialewp

    (@mialewp)

    Hello Rune Rasmussen,

    Good day!

    We appreciate your patience. After investigate and checking, we would like to inform that we will improve it in the next version.

    Thank you so much for your efforts! Please let us know if you have any further questions.

    Best regards,

    Mia

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Sale tag missing when using ‘Current discount tier’ display’ is closed to new replies.