Renamer leaves bad references in wp_postmeta

luckily Regenerate Thumbnails plugin seems to fix this.

Is this the right bit of code?

Regenerate Thumbnails:

$metadata = wp_generate_attachment_metadata( $image->ID, $fullsizepath );
if ( is_wp_error( $metadata ) )
	$this->die_json_error_msg( $image->ID, $metadata->get_error_message() );
if ( empty( $metadata ) )
	$this->die_json_error_msg( $image->ID, __( 'Unknown failure reason.', 'regenerate-thumbnails' ) );

// If this fails, then it just means that nothing was changed (old value == new value)
wp_update_attachment_metadata( $image->ID, $metadata );

Rename-media-files:

/* Update attachment's metadata */
wp_update_attachment_metadata( $post['ID'], wp_generate_attachment_metadata( $post['ID'], $new_file) );

/* Load global so that we can save to the database */
global $wpdb;

/* If image, get URLs to new sizes and update posts with old URLs */
if ( wp_attachment_is_image( $post['ID'] ) ) {
	foreach ( $image_sizes as $image_size ) {
		$orig_image_url = $orig_image_urls[$image_size];
		$new_image_data = wp_get_attachment_image_src( $post['ID'], $image_size );
		$new_image_url = $new_image_data[0];

		$wpdb->query( $wpdb->prepare( "UPDATE $wpdb->posts SET post_content = REPLACE(post_content, %s, %s);", $orig_image_url, $new_image_url ) );
	}
/* Otherwise, get URL to new file and update posts with old URL */
} else {
	$new_attachment_url = wp_get_attachment_url( $post['ID'] );

	$wpdb->query( $wpdb->prepare( "UPDATE $wpdb->posts SET post_content = REPLACE(post_content, %s, %s);" ), $orig_attachment_url, $new_attachment_url );
}

Jordy,
I see the same problem. It has been like this for months, but I just didn’t have time to investigate it.
The problem shows up when you have Featured images.
One of my writers uploads a file with a poorly-chosen name and I use Media File Renamer to change it. Then we select the image as the featured image and in the editor, it looks OK. Unfortunately, when it is published the image is broken, and the name of the broken image is the original filename.

Thank you for finding that Jonathan, saved me the trouble of exporting 50,000 database rows.

The only way to fix those bad images is the long way – export the image, rename it externally, re-import and re-add.

I hope you can correct this problem soon, Jordy. We love this PRO plugin!

@newsblaze, you can avoid the manual rename by using the renamer and then the Regenerate Thumbnails plugin., I did this and tested the results at the database end and it works fine.
[That said, I still turned off the Renamer for now until more time to fix it, I can’t rely on the users to remember to regenerate the images they have renamed.]

Thank you. I tried that and it seemed to work, but I was checking on today and this is what I found when I ran a reoptimize:

shamram-amiri-nuclear-scientist-100×70.jpg – No savings
shamram-amiri-nuclear-scientist-284×160.jpg – No savings
shamram-amiri-nuclear-scientist-80×60.jpg – No savings
shamram-amiri-nuclear-scientist-100×70.jpg – No savings
shamram-amiri-nuclear-scientist-218×150.jpg – No savings
shamram-amiri-nuclear-scientist-265×198.jpg – Reduced by 0.1% (7.0 B)
shamram-amiri-nuclear-scientist-324×160.jpg – No savings
shamram-amiri-nuclear-scientist-324×235.jpg – Reduced by 0.3% (39.0 B)
shamram-amiri-nuclear-scientist-324×361.jpg – Reduced by 0.3% (71.0 B)
shamram-amiri-nuclear-scientist-356×220.jpg – Reduced by 0.5% (71.0 B)
shamram-amiri-nuclear-scientist-534×361.jpg – Reduced by 0.9% (265.0 B)
sddefault-1-640×385.jpg – Reduced by 0.4% (114.0 B)
sddefault-1-560×420.jpg – Reduced by 1.8% (468.0 B)
Elapsed: 22.831 seconds

The theme sizing for the 560×420 is 0x420
but I have no idea how the 640×385 was generated.
So it seems Jordy’s MediaFile Renamer is looking at the database to see which images it should resize, but that can leave things behind.

So I uploaded a file called sddefault9.jpg and renamed it to test-rename.jpg and they all changed!
So right now, I can’t explain why those other ones were not renamed.
If I work it out, I will let you know.

If you like, I can give to one of you a clean install of WordPress somewhere, and on it we could try to replicate the issue. If we can replicate it easily, it will be also easily to find it and also fix it.

Sorry, I’ve been away Jordy. I will set up a clean install and come back to you.

No problem, I am loaded with work so it’s actually good you are giving me some time ??

I seem to have the same issue. I have to regenerate thumbnails each time after renaming images in order to correct some broken images on the site. I also run woocommerce. I also turn off renaming -and do it every so often. It takes the site quite a bit of time to regenerate thumbnails for several hundred images.