Remove Cookie from getContent

  • Resolved alduinwf

    (@alduinwf)


    5 months ago

    Dear Humans,

    I have a bunch of sites that I have to administrate using this plugin. In wp-appbox/inc/getappinfo.class.php you have this line:

    $cookie = tempnam( "/tmp", "CURLCOOKIE" );

    It creates an empty cookie file in /tmp that never gets deleted (maybe on a reboot, but you know). So I was deleting half a million files, with an uptime of just 20 days.

    So that is one thing that bothers me. But even worse is that this cookie is not even used. Like you have the file create, but $cookie is otherwise unused. So my proposal would be to remove this line as it does not seem to be needed anyway.

    Also, I am not really sure why the first order of business in the very same function is to sleep for 3 seconds?

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Marcelismus

    (@marcelismus)

    The sleep/timeout is needed to get informations from some stores (at some servers). You can remove it by yourself, but don’t wonder why some sites will detect your requests as bot (what it is, literally).

    Thread Starter alduinwf

    (@alduinwf)

    Fair enough.

    But the cookie thing is indeed literally unused. It appears once and only once in the whole file.

    View post on imgur.com
    $cookie exists only once in the file

    Since I do have a little “backup” (a folder “plugins-disabled”, from when I was testing something), I know that an old version used $cookie to provide curl with a cookie jar (and even deleted the cookie when done), but all that’s left now is creating the file and do nothing with it.

    Code for old version:

    View post on imgur.com
    Plugin Author Marcelismus

    (@marcelismus)

    Removed with 4.5.0.

    Thread Starter alduinwf

    (@alduinwf)

    Thank you very much ??

Viewing 4 replies - 1 through 4 (of 4 total)
  • You must be logged in to reply to this topic.